tailcall icon indicating copy to clipboard operation
tailcall copied to clipboard

Upgrade hyper to 1.0

Open tusharmath opened this issue 2 years ago • 10 comments

Renovate has created the base PR which doesn't pass the CI checks.

https://github.com/tailcallhq/tailcall/pull/636

Technical Requirements

  • Hyper version for both server should be updated to 1.0
  • No performance degradation should be observed
  • No tests should fail or require modification

tusharmath avatar Nov 17 '23 15:11 tusharmath

/bounty 120$

tusharmath avatar Nov 17 '23 15:11 tusharmath

💎 $120 bounty • Tailcall Inc.

Steps to solve:

  1. Start working: Comment /attempt #650 with your implementation plan
  2. Submit work: Create a pull request including /claim #650 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

🙏 Thank you for contributing to tailcallhq/tailcall! 🧐 Checkout our guidelines before you get started. 💵 More about our bounty program.

Attempt Started (GMT+0) Solution
🔴 @varshith257 May 14, 2024, 10:47:13 PM WIP
🟢 @ssddOnTop #2013

algora-pbc[bot] avatar Nov 17 '23 15:11 algora-pbc[bot]

Can you assign this to me

ssddOnTop avatar Nov 17 '23 15:11 ssddOnTop

@tusharmath I’ve not got any new tickets in a bit 🙌

ayewo avatar Nov 17 '23 15:11 ayewo

Can I be assigned to this ?

scshiv29-dev avatar Nov 17 '23 16:11 scshiv29-dev

@tusharmath I request you to assign this to me.

I have done some digging into the issue why the compilation is issue.

I think you should put this to hold because of two reasons.

  1. We heavily depend on hyper and reqwest
  2. hyper and reqwest are co-related here in this context thus reqwest also should be updated according to the version of hyper due to mis-matching type definitions.

We should wait till reqwest get's same version update that matches with hypers latest version (reqwest is going to be breaking change)

more on this https://github.com/seanmonstar/reqwest/issues/2039 Screenshot 2023-11-17 at 11 19 33 PM

b4s36t4 avatar Nov 17 '23 17:11 b4s36t4

Thanks @b4s36t4 .

@ayewo let me keep this unassigned until reqwest also upgrades.

tusharmath avatar Nov 18 '23 03:11 tusharmath

Action required: Issue inactive for 30 days. Status update or closure in 7 days.

github-actions[bot] avatar Apr 29 '24 12:04 github-actions[bot]

/attempt #650

Options

varshith257 avatar May 14 '24 22:05 varshith257

I won't be attempting this issue again.. for anyone who picks this up, you can refer to my previous PRs on how I handled requests (because hyper::Body is a trait now).

ssddOnTop avatar Jul 15 '24 08:07 ssddOnTop