tailcall icon indicating copy to clipboard operation
tailcall copied to clipboard

perf: Cache OperationPlan creation

Open ssddOnTop opened this issue 1 year ago • 3 comments
trafficstars

Issue Reference(s):
Fixes #2950

ssddOnTop avatar Oct 02 '24 04:10 ssddOnTop

🐰 Bencher Report

Branch2951/merge
Testbedbenchmarking-runner
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
nanoseconds (ns)
(Limit %)
from_json_bench📈 view plot
🚷 view threshold
6,245,600.00
(+0.19%)
6,392,485.75
(97.70%)
group_by📈 view plot
🚷 view threshold
486.94
(-0.74%)
513.43
(94.84%)
input/args.missing📈 view plot
🚷 view threshold
22.68
(-9.95%)
28.53
(79.51%)
input/args.nested.existing📈 view plot
🚷 view threshold
43.93
(-2.63%)
48.28
(91.00%)
input/args.nested.missing📈 view plot
🚷 view threshold
37.93
(-1.25%)
40.93
(92.67%)
input/args.root📈 view plot
🚷 view threshold
38.56
(-5.55%)
44.25
(87.15%)
input/headers.existing📈 view plot
🚷 view threshold
32.41
(+2.11%)
34.13
(94.96%)
input/headers.missing📈 view plot
🚷 view threshold
31.89
(+3.16%)
33.78
(94.38%)
input/value.missing📈 view plot
🚷 view threshold
23.65
(+0.65%)
24.72
(95.66%)
input/value.nested.existing📈 view plot
🚷 view threshold
43.44
(+0.64%)
45.71
(95.03%)
input/value.nested.missing📈 view plot
🚷 view threshold
37.20
(+1.91%)
38.35
(97.00%)
input/value.root📈 view plot
🚷 view threshold
38.76
(-0.92%)
42.35
(91.52%)
input/vars.existing📈 view plot
🚷 view threshold
7.46
(-9.01%)
9.48
(78.68%)
input/vars.missing📈 view plot
🚷 view threshold
10.00
(+0.14%)
13.26
(75.40%)
synth_nested📈 view plot
🚷 view threshold
136,100.00
(+12.04%)
164,140.99
(82.92%)
synth_nested_borrow📈 view plot
🚷 view threshold
93,543.00
(+34.98%)
113,137.05
(82.68%)
test_batched_body📈 view plot
🚷 view threshold
1,885.80
(-0.83%)
1,983.12
(95.09%)
test_batched_body #2📈 view plot
🚷 view threshold
1,509,300.00
(-1.73%)
1,635,167.58
(92.30%)
test_data_loader📈 view plot
🚷 view threshold
384,530.00
(-5.94%)
438,365.16
(87.72%)
test_handle_request📈 view plot
🚷 view threshold
129,560.00
(-4.01%)
145,929.51
(88.78%)
test_handle_request_jit📈 view plot
🚷 view threshold
86,818.00
(-23.60%)
147,931.67
(58.69%)
test_http_execute_method📈 view plot
🚷 view threshold
14,866.00
(+3.43%)
14,958.92
(99.38%)
with_mustache_expressions📈 view plot
🚷 view threshold
1,071.40
(-3.61%)
1,180.31
(90.77%)
with_mustache_literal📈 view plot
🚷 view threshold
702.62
(-0.97%)
760.27
(92.42%)
🐰 View full continuous benchmarking report in Bencher

github-actions[bot] avatar Oct 02 '24 05:10 github-actions[bot]

Here is the flameGraph for hello world for this pr flamegraph Here is the flamegraph for hello world for main flamegraph_main

amitksingh1490 avatar Oct 02 '24 06:10 amitksingh1490

moving this to draft till #https://github.com/tailcallhq/tailcall/pull/2953 is merged

ssddOnTop avatar Oct 04 '24 02:10 ssddOnTop

Codecov Report

Attention: Patch coverage is 98.02632% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.71%. Comparing base (43d9975) to head (78891c5). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/jit/transform/check_dedupe.rs 92.85% 2 Missing :warning:
src/core/jit/graphql_executor.rs 95.00% 1 Missing :warning:
src/core/jit/response.rs 0.00% 1 Missing :warning:
tailcall-aws-lambda/src/runtime.rs 0.00% 1 Missing :warning:
tailcall-wasm/src/runtime.rs 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2951      +/-   ##
==========================================
- Coverage   87.74%   87.71%   -0.03%     
==========================================
  Files         276      279       +3     
  Lines       27437    27453      +16     
==========================================
+ Hits        24074    24081       +7     
- Misses       3363     3372       +9     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 05 '24 17:10 codecov[bot]

I'm working by myself on the comments I provided in a separate branch, please ignore them

meskill avatar Oct 09 '24 11:10 meskill

I'm working by myself on the comments I provided in a separate branch, please ignore them

@meskill I think I already fixed some of them yesterday, I’ll push those changes soon

ssddOnTop avatar Oct 09 '24 13:10 ssddOnTop