tailcall icon indicating copy to clipboard operation
tailcall copied to clipboard

refactor(2671): move retry logic and implement tokio_retry

Open onyedikachi-david opened this issue 1 year ago • 10 comments

Summary:
This refactor enhances the of API calls by leveraging tokio_retry for automatic retries with an exponential backoff strategy.

  • Moved retry logic from InferTypeName to Wizard struct
  • Implemented tokio_retry with ExponentialBackoff strategy

Issue Reference(s):
Fixes #2671 /claim #2671

Build & Testing:

  • [ ] I ran cargo test successfully.
  • [ ] I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • [ ] I have added relevant unit & integration tests.
  • [ ] I have updated the documentation accordingly.
  • [x] I have performed a self-review of my code.
  • [x] PR follows the naming convention of <type>(<optional scope>): <title>

onyedikachi-david avatar Aug 12 '24 17:08 onyedikachi-david

duplicate of #2673

ssddOnTop avatar Aug 12 '24 17:08 ssddOnTop

duplicate of #2673

Not at all, if not for slow compilation on my laptop i would have submitted before now. @ssddOnTop

onyedikachi-david avatar Aug 12 '24 17:08 onyedikachi-david

Codecov Report

Attention: Patch coverage is 0% with 51 lines in your changes missing coverage. Please review.

Project coverage is 86.25%. Comparing base (865d1e5) to head (dc811b8). Report is 22 commits behind head on main.

Files Patch % Lines
src/cli/llm/wizard.rs 0.00% 37 Missing :warning:
src/cli/llm/infer_type_name.rs 0.00% 14 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2674      +/-   ##
==========================================
- Coverage   86.31%   86.25%   -0.07%     
==========================================
  Files         255      255              
  Lines       24673    24691      +18     
==========================================
  Hits        21297    21297              
- Misses       3376     3394      +18     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 13 '24 08:08 codecov[bot]

Moving to draft to reduce noise and improve CI efficiency. Once you are ready just mark it as "ready to review". Feel free to give a shoutout on the #contributors channel on Discord if you want immediate attention.

tusharmath avatar Aug 14 '24 13:08 tusharmath

Action required: PR inactive for 5 days. Status update or closure in 10 days.

github-actions[bot] avatar Aug 19 '24 14:08 github-actions[bot]

Action required: PR inactive for 5 days. Status update or closure in 10 days.

github-actions[bot] avatar Aug 26 '24 09:08 github-actions[bot]

Moving to draft to reduce noise and improve CI efficiency. Once you are ready just mark it as "ready to review". Feel free to give a shoutout on the #contributors channel on Discord if you want immediate attention.

tusharmath avatar Aug 27 '24 18:08 tusharmath

Action required: PR inactive for 5 days. Status update or closure in 10 days.

github-actions[bot] avatar Sep 08 '24 23:09 github-actions[bot]

PR closed after 10 days of inactivity.

github-actions[bot] avatar Sep 18 '24 23:09 github-actions[bot]

Action required: PR inactive for 5 days. Status update or closure in 10 days.

github-actions[bot] avatar Sep 29 '24 17:09 github-actions[bot]

Hey @onyedikachi-david thanks for the pr. Would you able to finish this based on the discussions?

meskill avatar Oct 07 '24 13:10 meskill

Hey @onyedikachi-david thanks for the pr. Would you able to finish this based on the discussions?

Okay. I'll push the needed changes in few hours time.

onyedikachi-david avatar Oct 07 '24 16:10 onyedikachi-david

webc isn't public in this repo: https://github.com/tailcallhq/rust-genai; hence I can't implement some of the requested changes.

onyedikachi-david avatar Oct 08 '24 23:10 onyedikachi-david

Action required: PR inactive for 5 days. Status update or closure in 10 days.

github-actions[bot] avatar Oct 14 '24 21:10 github-actions[bot]

PR closed after 10 days of inactivity.

github-actions[bot] avatar Oct 24 '24 21:10 github-actions[bot]