tailcall icon indicating copy to clipboard operation
tailcall copied to clipboard

refactor: store __typename in value instead of separate entity

Open meskill opened this issue 1 year ago • 1 comments

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • [ ] I ran cargo test successfully.
  • [ ] I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • [ ] I have added relevant unit & integration tests.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have performed a self-review of my code.
  • [ ] PR follows the naming convention of <type>(<optional scope>): <title>

meskill avatar Aug 07 '24 21:08 meskill

Codecov Report

Attention: Patch coverage is 56.83453% with 60 lines in your changes missing coverage. Please review.

Project coverage is 86.31%. Comparing base (9a50f13) to head (d93aab2). Report is 1 commits behind head on main.

Files Patch % Lines
src/core/jit/builder.rs 5.00% 19 Missing :warning:
src/core/json/borrow.rs 0.00% 15 Missing :warning:
src/core/json/serde.rs 0.00% 13 Missing :warning:
src/core/json/graphql.rs 56.25% 7 Missing :warning:
src/core/json/json_like_list.rs 68.75% 5 Missing :warning:
src/core/ir/discriminator.rs 92.30% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2626      +/-   ##
==========================================
- Coverage   86.46%   86.31%   -0.15%     
==========================================
  Files         255      256       +1     
  Lines       24972    24999      +27     
==========================================
- Hits        21593    21579      -14     
- Misses       3379     3420      +41     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 07 '24 21:08 codecov[bot]

🐰Bencher

ReportMon, August 26, 2024 at 10:40:34 UTC
Projecttailcall
Branch2626/merge
Testbedbenchmarking-runner

🚨 3 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
input/vars.missingLatency (nanoseconds (ns))🚨 (view plot | view alert)11.45 (+32.49%)11.12 (102.99%)
synth_nested_borrowLatency (nanoseconds (ns))🚨 (view plot | view alert)70,359.00 (+93.68%)67,839.56 (103.71%)
test_handle_request_jitLatency (nanoseconds (ns))🚨 (view plot | view alert)140,560.00 (+36.20%)131,729.87 (106.70%)

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
from_json_bench✅ (view plot)6,227,400.00 (-0.42%)6,867,035.10 (90.69%)
group_by✅ (view plot)481.18 (-2.82%)536.18 (89.74%)
input/args.missing✅ (view plot)25.48 (-0.74%)28.47 (89.48%)
input/args.nested.existing✅ (view plot)46.01 (-3.09%)55.60 (82.74%)
input/args.nested.missing✅ (view plot)38.65 (-0.16%)40.83 (94.65%)
input/args.root✅ (view plot)43.36 (-0.65%)52.69 (82.30%)
input/headers.existing✅ (view plot)32.65 (+3.39%)34.08 (95.80%)
input/headers.missing✅ (view plot)31.62 (+3.21%)33.44 (94.54%)
input/value.missing✅ (view plot)23.36 (-0.07%)24.65 (94.75%)
input/value.nested.existing✅ (view plot)42.26 (-1.06%)45.78 (92.31%)
input/value.nested.missing✅ (view plot)34.80 (-5.68%)39.71 (87.65%)
input/value.root✅ (view plot)38.82 (+1.30%)41.08 (94.51%)
input/vars.existing✅ (view plot)8.37 (+1.81%)9.74 (85.91%)
input/vars.missing🚨 (view plot | view alert)11.45 (+32.49%)11.12 (102.99%)
synth_nested✅ (view plot)127,440.00 (+27.47%)195,838.58 (65.07%)
synth_nested_borrow🚨 (view plot | view alert)70,359.00 (+93.68%)67,839.56 (103.71%)
test_batched_body✅ (view plot)1,902.80 (-6.54%)2,475.66 (76.86%)
test_batched_body #2✅ (view plot)1,495,600.00 (-7.68%)1,765,041.42 (84.73%)
test_data_loader✅ (view plot)422,320.00 (+3.41%)477,732.38 (88.40%)
test_handle_request✅ (view plot)129,690.00 (-9.71%)153,862.84 (84.29%)
test_handle_request_jit🚨 (view plot | view alert)140,560.00 (+36.20%)131,729.87 (106.70%)
test_http_execute_method✅ (view plot)14,286.00 (-2.73%)16,828.64 (84.89%)
with_mustache_expressions✅ (view plot)1,088.20 (-2.32%)1,184.77 (91.85%)
with_mustache_literal✅ (view plot)691.28 (-3.47%)769.96 (89.78%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

github-actions[bot] avatar Aug 19 '24 10:08 github-actions[bot]

Action required: PR inactive for 5 days. Status update or closure in 10 days.

github-actions[bot] avatar Aug 26 '24 10:08 github-actions[bot]