tailcall icon indicating copy to clipboard operation
tailcall copied to clipboard

fix: Enable JS build for all architecture

Open varshith257 opened this issue 1 year ago • 2 comments

Summary:
Updated the CI to build Tailcall on all supported platforms without any feature flags

  • Unsupported platforms

  • [x] linux-x64-musl

  • [x] linux-arm64-musl

  • [x] linux-ia32-gnu

  • [x] win32-x64-gnu

  • [x] win32-arm64-msvc

  • [x] win32-ia32-gnu

Issue Reference(s):

Fixes #1869 /claim #1869

Build & Testing:

  • [x] I ran cargo test successfully.
  • [x] I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • [x] I have added relevant unit & integration tests.
  • [x] I have updated the documentation accordingly.
  • [x] I have performed a self-review of my code.
  • [x] PR follows the naming convention of <type>(<optional scope>): <title>

varshith257 avatar May 14 '24 21:05 varshith257

@tusharmath @amitksingh1490 Can I get approval for workflows to trigger?

varshith257 avatar May 14 '24 21:05 varshith257

@tusharmath The failing test is due to codecov token. The reason for is as below. We need to add upload token ig

https://docs.codecov.com/docs/adding-the-codecov-token

error - 2024-05-15 08:03:08,161 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 99 seconds."}

varshith257 avatar May 15 '24 08:05 varshith257