fix: allow default values for input arguments
Issue Reference(s):
Fixes #1931
/claim 1931
Codecov Report
Attention: Patch coverage is 93.10345% with 2 lines in your changes are missing coverage. Please review.
Project coverage is 82.10%. Comparing base (
630254a) to head (c6aaf67).
:exclamation: Current head c6aaf67 differs from pull request most recent head 73b2720
Please upload reports for the commit 73b2720 to get more accurate results.
| Files | Patch % | Lines |
|---|---|---|
| src/core/blueprint/into_schema.rs | 93.10% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #1939 +/- ##
==========================================
- Coverage 82.79% 82.10% -0.70%
==========================================
Files 183 173 -10
Lines 18243 17644 -599
==========================================
- Hits 15104 14486 -618
- Misses 3139 3158 +19
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Bencher
| Report | Sat, May 18, 2024 at 03:45:12 UTC |
| Project | tailcall |
| Branch | 1939/merge |
| Testbed | benchmarking-runner |
🚨 1 ALERT: Threshold Boundary Limit exceeded!
| Benchmark | Measure (units) | View | Value | Lower Boundary | Upper Boundary |
|---|---|---|---|---|---|
| input/vars.missing | Latency (nanoseconds (ns)) | 🚨 (view plot | view alert) | 11.73 (+37.26%) | 10.95 (107.14%) |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|
| group_by | ✅ (view plot) | 535.10 (-10.68%) | 648.29 (82.54%) |
| input/args.missing | ✅ (view plot) | 22.93 (-7.37%) | 27.22 (84.23%) |
| input/args.nested.existing | ✅ (view plot) | 42.66 (-18.05%) | 65.96 (64.67%) |
| input/args.nested.missing | ✅ (view plot) | 37.38 (-3.00%) | 40.63 (92.01%) |
| input/args.root | ✅ (view plot) | 37.92 (-21.97%) | 62.51 (60.67%) |
| input/headers.existing | ✅ (view plot) | 33.03 (+3.91%) | 33.50 (98.61%) |
| input/headers.missing | ✅ (view plot) | 31.55 (+2.47%) | 33.37 (94.52%) |
| input/value.missing | ✅ (view plot) | 23.19 (-1.54%) | 25.36 (91.41%) |
| input/value.nested.existing | ✅ (view plot) | 42.07 (+1.40%) | 43.95 (95.72%) |
| input/value.nested.missing | ✅ (view plot) | 36.84 (+1.19%) | 38.34 (96.09%) |
| input/value.root | ✅ (view plot) | 37.57 (-2.40%) | 40.38 (93.04%) |
| input/vars.existing | ✅ (view plot) | 7.44 (-8.94%) | 9.06 (82.05%) |
| input/vars.missing | 🚨 (view plot | view alert) | 11.73 (+37.26%) | 10.95 (107.14%) |
| test_batched_body | ✅ (view plot) | 2,682.70 (-99.69%) | 2,654,750.22 (0.10%) |
| test_batched_body #2 | ✅ (view plot) | 1,634,100.00 (-6.06%) | 1,888,131.04 (86.55%) |
| test_data_loader | ✅ (view plot) | 460,710.00 (-2.46%) | 490,377.11 (93.95%) |
| test_handle_request | ✅ (view plot) | 157,400.00 (-7.82%) | 182,978.09 (86.02%) |
| with_mustache_expressions | ✅ (view plot) | 1,183.80 (+1.04%) | 1,236.24 (95.76%) |
| with_mustache_literal | ✅ (view plot) | 741.64 (+2.43%) | 772.57 (96.00%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
Action required: PR inactive for 2 days. Status update or closure in 5 days.
Action required: PR inactive for 2 days. Status update or closure in 5 days.
there is an issue with async-graphql as well, I raised a PR https://github.com/async-graphql/async-graphql/pull/1527 there if it gets merged, I'll finish touchups in this PR.
Action required: PR inactive for 2 days. Status update or closure in 5 days.
Action required: PR inactive for 2 days. Status update or closure in 5 days.
Action required: PR inactive for 2 days. Status update or closure in 5 days.