tailcall
tailcall copied to clipboard
perf: replacing HashMap with TailcallHashMap
Summary:
Briefly describe the changes made in this PR.
Issue Reference(s):
Fixes #... (Replace "..." with the issue number)
Build & Testing:
- [ ] I ran
cargo testsuccessfully. - [ ] I have run
./lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.
Checklist:
- [ ] I have added relevant unit & integration tests.
- [ ] I have updated the documentation accordingly.
- [ ] I have performed a self-review of my code.
- [ ] PR follows the naming convention of
<type>(<optional scope>): <title>
Codecov Report
Attention: Patch coverage is 97.05882% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 89.74%. Comparing base (
2b98fde) to head (6687ee0). Report is 26 commits behind head on perf/base.
:exclamation: Current head 6687ee0 differs from pull request most recent head 8b706ca
Please upload reports for the commit 8b706ca to get more accurate results.
| Files | Patch % | Lines |
|---|---|---|
| src/core/json/json_like.rs | 75.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## perf/base #1933 +/- ##
==========================================
Coverage 89.73% 89.74%
==========================================
Files 155 155
Lines 15837 15842 +5
==========================================
+ Hits 14212 14217 +5
Misses 1625 1625
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Bencher
| Report | Mon, May 13, 2024 at 14:55:03 UTC |
| Project | tailcall |
| Branch | 1933/merge |
| Testbed | benchmarking-runner |
🚨 2 ALERTS: Threshold Boundary Limits exceeded!
| Benchmark | Measure (units) | View | Value | Lower Boundary | Upper Boundary |
|---|---|---|---|---|---|
| input/vars.missing | Latency (nanoseconds (ns)) | 🚨 (view plot | view alert) | 11.02 (+35.09%) | 9.32 (118.24%) | |
| with_mustache_literal | Latency (nanoseconds (ns)) | 🚨 (view plot | view alert) | 775.27 (+7.09%) | 767.32 (101.04%) |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|
| group_by | ✅ (view plot) | 521.54 (-13.95%) | 638.29 (81.71%) |
| input/args.missing | ✅ (view plot) | 23.11 (-7.61%) | 27.14 (85.14%) |
| input/args.nested.existing | ✅ (view plot) | 42.31 (-20.94%) | 65.62 (64.49%) |
| input/args.nested.missing | ✅ (view plot) | 37.04 (-4.18%) | 40.73 (90.94%) |
| input/args.root | ✅ (view plot) | 35.65 (-28.90%) | 61.92 (57.57%) |
| input/headers.existing | ✅ (view plot) | 32.86 (+3.33%) | 33.35 (98.55%) |
| input/headers.missing | ✅ (view plot) | 31.59 (+2.83%) | 32.83 (96.24%) |
| input/value.missing | ✅ (view plot) | 23.32 (-1.02%) | 25.28 (92.26%) |
| input/value.nested.existing | ✅ (view plot) | 40.57 (-2.00%) | 43.55 (93.15%) |
| input/value.nested.missing | ✅ (view plot) | 36.93 (+1.71%) | 38.22 (96.61%) |
| input/value.root | ✅ (view plot) | 37.64 (-2.61%) | 40.03 (94.04%) |
| input/vars.existing | ✅ (view plot) | 7.13 (-13.61%) | 9.02 (79.06%) |
| input/vars.missing | 🚨 (view plot | view alert) | 11.02 (+35.09%) | 9.32 (118.24%) |
| test_batched_body | ✅ (view plot) | 2,625.50 (-99.73%) | 2,762,825.51 (0.10%) |
| test_batched_body #2 | ✅ (view plot) | 1,656,000.00 (-5.98%) | 1,892,991.67 (87.48%) |
| test_data_loader | ✅ (view plot) | 462,180.00 (-2.38%) | 490,484.17 (94.23%) |
| test_handle_request | ✅ (view plot) | 169,680.00 (-1.71%) | 182,448.06 (93.00%) |
| with_mustache_expressions | ✅ (view plot) | 1,178.00 (+0.29%) | 1,237.83 (95.17%) |
| with_mustache_literal | 🚨 (view plot | view alert) | 775.27 (+7.09%) | 767.32 (101.04%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
Action required: PR inactive for 2 days. Status update or closure in 5 days.
Action required: PR inactive for 2 days. Status update or closure in 5 days.
No improvement