tailcall icon indicating copy to clipboard operation
tailcall copied to clipboard

chore: Automatically Resolve Ambiguous Types in Configuration

Open ssddOnTop opened this issue 1 year ago • 1 comments

Sample command:
cargo run -- gen tailcall-fixtures/fixtures/generator/proto/news.proto -i proto -o gql -r 'prefix=IPrefix_ suffix=_ISuffix'

Issue Reference(s):
Fixes #1870 /claim 1870

TODO:

  • [x] The Tailcall CLI no longer throws errors when the same type is used in both the input and output sections of the configuration.
  • [x] Ambiguous type are automatically detected and resolved using the resolve_ambiguous_types function.
  • [ ] Integration test for this using execution_spec should be added.

ssddOnTop avatar May 13 '24 08:05 ssddOnTop

Codecov Report

Attention: Patch coverage is 85.07463% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 90.12%. Comparing base (186fd6b) to head (1e27921). Report is 30 commits behind head on main.

Files Patch % Lines
src/cli/tc.rs 83.69% 15 Missing :warning:
src/core/generator/generator.rs 82.35% 3 Missing :warning:
src/core/config/config_module.rs 88.23% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1924      +/-   ##
==========================================
+ Coverage   89.73%   90.12%   +0.38%     
==========================================
  Files         155      155              
  Lines       15837    15929      +92     
==========================================
+ Hits        14212    14356     +144     
+ Misses       1625     1573      -52     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 13 '24 10:05 codecov[bot]

Action required: PR inactive for 2 days. Status update or closure in 5 days.

github-actions[bot] avatar May 16 '24 08:05 github-actions[bot]

Action required: PR inactive for 2 days. Status update or closure in 5 days.

github-actions[bot] avatar May 18 '24 15:05 github-actions[bot]

PR closed after 5 days of inactivity.

github-actions[bot] avatar May 23 '24 16:05 github-actions[bot]