tailcall icon indicating copy to clipboard operation
tailcall copied to clipboard

chore: removing `Clone` derivation from `Blueprint`

Open shashitnak opened this issue 9 months ago • 4 comments

Summary:
Using Arc to optimize cloning of Blueprint

Issue Reference(s):
Fixes #1858

Build & Testing:

  • [x] I ran cargo test successfully.
  • [x] I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • [ ] I have added relevant unit & integration tests.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have performed a self-review of my code.
  • [x] PR follows the naming convention of <type>(<optional scope>): <title>

shashitnak avatar May 06 '24 09:05 shashitnak

Codecov Report

Attention: Patch coverage is 90.38462% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 89.71%. Comparing base (6fbeebc) to head (4ca1793). Report is 33 commits behind head on main.

Files Patch % Lines
src/core/arc_string.rs 81.25% 9 Missing :warning:
src/core/http/telemetry.rs 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1871      +/-   ##
==========================================
- Coverage   89.73%   89.71%   -0.03%     
==========================================
  Files         154      155       +1     
  Lines       15817    15871      +54     
==========================================
+ Hits        14193    14238      +45     
- Misses       1624     1633       +9     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 06 '24 09:05 codecov[bot]

🐰Bencher

ReportFri, May 10, 2024 at 10:04:56 UTC
Projecttailcall
Branch1871/merge
Testbedbenchmarking-runner

🚨 2 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
input/vars.existingLatency (nanoseconds (ns))🚨 (view plot | view alert)23.56 (+179.53%)11.42 (206.38%)
input/vars.missingLatency (nanoseconds (ns))🚨 (view plot | view alert)29.51 (+255.87%)12.45 (237.14%)

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
group_by✅ (view plot)611.63 (+0.70%)632.55 (96.69%)
input/args.missing✅ (view plot)23.12 (-7.97%)26.91 (85.91%)
input/args.nested.existing✅ (view plot)41.24 (-24.16%)64.96 (63.49%)
input/args.nested.missing✅ (view plot)37.75 (-2.67%)40.64 (92.91%)
input/args.root✅ (view plot)37.74 (-26.02%)61.12 (61.75%)
input/headers.existing✅ (view plot)31.61 (-0.30%)32.97 (95.86%)
input/headers.missing✅ (view plot)30.41 (-0.62%)32.42 (93.78%)
input/value.missing✅ (view plot)23.35 (-0.81%)25.03 (93.31%)
input/value.nested.existing✅ (view plot)41.28 (-0.10%)43.14 (95.70%)
input/value.nested.missing✅ (view plot)37.22 (+2.74%)38.12 (97.65%)
input/value.root✅ (view plot)37.79 (-2.28%)39.93 (94.63%)
input/vars.existing🚨 (view plot | view alert)23.56 (+179.53%)11.42 (206.38%)
input/vars.missing🚨 (view plot | view alert)29.51 (+255.87%)12.45 (237.14%)
test_batched_body✅ (view plot)2,631.80 (-99.75%)2,811,147.56 (0.09%)
test_batched_body #2✅ (view plot)1,749,300.00 (-1.37%)1,899,472.31 (92.09%)
test_data_loader✅ (view plot)474,670.00 (+0.23%)490,652.15 (96.74%)
test_handle_request✅ (view plot)167,410.00 (-3.30%)184,655.53 (90.66%)
with_mustache_expressions✅ (view plot)1,151.60 (-1.87%)1,236.82 (93.11%)
with_mustache_literal✅ (view plot)726.11 (+0.46%)764.83 (94.94%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

github-actions[bot] avatar May 06 '24 10:05 github-actions[bot]

@tusharmath How to trigger this bencher action on some pr?

webbdays avatar May 06 '24 13:05 webbdays

Action required: PR inactive for 2 days. Status update or closure in 5 days.

github-actions[bot] avatar May 12 '24 12:05 github-actions[bot]

Action required: PR inactive for 2 days. Status update or closure in 5 days.

github-actions[bot] avatar May 16 '24 13:05 github-actions[bot]

Action required: PR inactive for 2 days. Status update or closure in 5 days.

github-actions[bot] avatar May 20 '24 17:05 github-actions[bot]

PR closed after 5 days of inactivity.

github-actions[bot] avatar May 25 '24 18:05 github-actions[bot]