tailcall icon indicating copy to clipboard operation
tailcall copied to clipboard

Drop responseValidation in `@server`

Open amitksingh1490 opened this issue 9 months ago • 1 comments

We are currently performing explicit validation of responses within our GraphQL executor based on responseValidation setting in @server directive . However, this might be redundant as GraphQL inherently includes capabilities for validating values against the schema.

Proposed Changes

  • [ ] Remove all code segments explicitly dedicated to response validation in the GraphQL executor.
  • [ ] Refactor any affected tests.
  • [ ] Update relevant documentation.

amitksingh1490 avatar Apr 30 '24 12:04 amitksingh1490

@amitksingh1490 current implementation don't validate the response with schema based on types (if we remove the responseValidation flag). so in order to provide the option of type validation we have to support responseValidation setting in @server directive.

data type based validation only performed when responseValidation setting is true. code for ref: https://github.com/tailcallhq/tailcall/blob/c7a25cb3777d3370cfceb3be013d1c70849d9ed9/src/lambda/io.rs#L90

laststylebender14 avatar May 01 '24 11:05 laststylebender14

Action required: Issue inactive for 30 days. Status update or closure in 7 days.

github-actions[bot] avatar May 31 '24 12:05 github-actions[bot]

Issue closed after 7 days of inactivity.

github-actions[bot] avatar Jun 07 '24 15:06 github-actions[bot]