taiko-mono icon indicating copy to clipboard operation
taiko-mono copied to clipboard

feat(protocol): make bridge processMessage return message's status and reason

Open dantaik opened this issue 9 months ago • 3 comments

@KorbinianK please confirm if you need this.

dantaik avatar May 08 '24 07:05 dantaik

feat(protocol): make bridge processMessage return message's status and reason

Generated at commit: 82e7d6258300267bbfea2def97bfa2576b8ad21e

🚨 Report Summary

Severity Level Results
Contracts Critical High Medium Low Note Total 2 2 0 5 41 50
Dependencies Critical High Medium Low Note Total 0 0 0 0 0 0

For more details view the full report in OpenZeppelin Code Inspector

openzeppelin-code[bot] avatar May 08 '24 07:05 openzeppelin-code[bot]

@dantaik I need the return value, otherwise I cannot determine whether a transaction will go to retriable via simulateContract. It does not emit events during simulation (eth_call does not return events).

But even with the return of message status, I won't know the reason for it. Should we return the reason for the status change as well?

KorbinianK avatar May 08 '24 09:05 KorbinianK

@dantaik I need the return value, otherwise I cannot determine whether a transaction will go to retriable via simulateContract. It does not emit events during simulation (eth_call does not return events).

But even with the return of message status, I won't know the reason for it. Should we return the reason for the status change as well?

Added a reason to the return of processMessage

dantaik avatar May 08 '24 12:05 dantaik