taiko-mono icon indicating copy to clipboard operation
taiko-mono copied to clipboard

chore(eventindexer): enhance indexer filter fetching latest block

Open fenghaojiang opened this issue 9 months ago • 3 comments

chore(indexer): enhance indexer filter fetching latest block by replacing HeaderByNumber by BlockNumber

Previous: Using HeaderByNumber but other fields(except block number) not being used. Fetching latest block by BlockNumber should be better.

fenghaojiang avatar May 04 '24 06:05 fenghaojiang

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 17.71%. Comparing base (f53766b) to head (8ff0755). Report is 430 commits behind head on main.

Files Patch % Lines
packages/eventindexer/indexer/filter.go 0.00% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16981      +/-   ##
==========================================
- Coverage   26.82%   17.71%   -9.12%     
==========================================
  Files         105       45      -60     
  Lines        6188     1987    -4201     
==========================================
- Hits         1660      352    -1308     
+ Misses       4348     1594    -2754     
+ Partials      180       41     -139     
Flag Coverage Δ
eventindexer 17.71% <0.00%> (+0.49%) :arrow_up:
guardian-prover-health-check ?
relayer ?

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 05 '24 03:05 codecov[bot]

@fenghaojiang I guess you need to rebase main branch in your PR.

xiaodino avatar May 05 '24 05:05 xiaodino

@fenghaojiang I guess you need to rebase main branch in your PR.

Already rebased. Plz review it again.

fenghaojiang avatar May 05 '24 05:05 fenghaojiang

Approved, LGTM.

cyberhorsey avatar May 06 '24 01:05 cyberhorsey

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Taiko Contributor:

GitPOAP: 2024 Taiko Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

gitpoap-bot[bot] avatar May 06 '24 01:05 gitpoap-bot[bot]