taiko-mono icon indicating copy to clipboard operation
taiko-mono copied to clipboard

chore(repo): add taiko-client to taiko-mono

Open dionysuzx opened this issue 9 months ago • 1 comments

summary of changes

This PR adds taiko-client into taiko-mono, so it can benefit from our CICD. There are two commits to review this PR:

  • ae582fe is an exact copy of taiko-client at commit d2e9667. you can verify this with something like diff -r packages/taiko-client ../taiko-client if you have taiko-mono and taiko-client in the same directory on your local machine.
  • 7164f8e this is where i make the necessary modifications to integrate taiko-client into taiko-mono. it is only removing taiko-mono directory dependency, merging the go.mod deps, and fixing the CICD workflows.

next steps

  1. Let this merge into taiko-mono.
  2. Add the GAR_JSON_KEY to taiko-mono for the docker job. <- @davidtaikocha
  3. Rebase all PRs in taiko-client against this and open in taiko-mono, you'll just need to replace the workspace module path: github.com/taikoxyz/taiko-client -> github.com/taikoxyz/taiko-mono/packages/taiko-client.
  4. Move any github issues from taiko-client to taiko-mono. <- @d1onys1us
  5. Mark taiko-client as a public readonly archive, and remove it from the taikoxyz pinned repos. <- @dantaik

dionysuzx avatar May 01 '24 22:05 dionysuzx

According to @davidtaikocha there is one or two changes that needs to be merged into the codebase before merging this PR.

dantaik avatar May 07 '24 02:05 dantaik

@dantaik @davidtaikocha i fixed up this PR and got it ready for review. you can check my description, i split the PR into three logically separated commits for easier review of the changes.

dionysuzx avatar May 08 '24 02:05 dionysuzx