taiko-mono icon indicating copy to clipboard operation
taiko-mono copied to clipboard

feat(repo): refactor blob storage pkg

Open cyberhorsey opened this issue 11 months ago • 2 comments

This Pr brings Dani's blob-catcher software up to speed with our existing architectural patterns., fixed some bugs, and cleans up the code, as well as fixes logging.

It initializes an ethclient / db connection once, rather than for every event it finds, and as well, it gets events in batches (as before, it was getting infinite number of block data at once, which would cause it to crash if too many blocks). Then, when it is caught up, it subscribes to new blocks.

@adaki2004 can i take out MongoDB and make it MySQL? we already use MySQL in production, dont see the need for two different database. Or is there a reason we use Mongo here?

cyberhorsey avatar Mar 11 '24 20:03 cyberhorsey

What u mean by WIP

m3shm avatar Mar 11 '24 21:03 m3shm

What u mean by WIP

work in progress. who are you?

cyberhorsey avatar Mar 11 '24 21:03 cyberhorsey

@adaki2004 can i take out MongoDB and make it MySQL? we already use MySQL in production, dont see the need for two different database. Or is there a reason we use Mongo here?

imo we should also use MySQL for this service, can't any reason to maintain a new type of database?

davidtaikocha avatar Mar 12 '24 02:03 davidtaikocha

@adaki2004 can i take out MongoDB and make it MySQL? we already use MySQL in production, dont see the need for two different database. Or is there a reason we use Mongo here?

imo we should also use MySQL for this service, can't any reason to maintain a new type of database?

don't think so, it was just started with Mongo. I will swap it out for MySQL.

cyberhorsey avatar Mar 12 '24 04:03 cyberhorsey

@adaki2004 can i take out MongoDB and make it MySQL? we already use MySQL in production, dont see the need for two different database. Or is there a reason we use Mongo here?

imo we should also use MySQL for this service, can't any reason to maintain a new type of database?

don't think so, it was just started with Mongo. I will swap it out for MySQL.

yep, made more sense starting with it (as discussed in taiko discord, horizontal scaling, no need for relational DB) but since we already have an infra for a db which is mysql, makes more sense to re-use it!

adaki2004 avatar Mar 12 '24 08:03 adaki2004