taiko-mono icon indicating copy to clipboard operation
taiko-mono copied to clipboard

chore(repo): add blob-catcher to monorepo

Open dionysuzx opened this issue 11 months ago • 4 comments

summary

  • add blob-catcher to monorepo
  • add steps to adding a repo to monorepo to CONTRIBUTING.md

dionysuzx avatar Mar 07 '24 19:03 dionysuzx

@adaki2004 We need README.md to start with...

dantaik avatar Mar 08 '24 03:03 dantaik

@adaki2004 We need README.md to start with...

Isn't it good, or what kind of readme.md you want to see ? https://github.com/taikoxyz/taiko-mono/blob/4bde8d59e01b7a99eda6c26c850e6d34f5d58fde/packages/blob-storage/README.md

adaki2004 avatar Mar 08 '24 09:03 adaki2004

I was requested to review this but don't know what I'm reviewing. @d1onys1us any context? It prints blobs out from blocks? who wrote it originally

cyberhorsey avatar Mar 09 '24 01:03 cyberhorsey

I was requested to review this but don't know what I'm reviewing. @d1onys1us any context? It prints blobs out from blocks? who wrote it originally

Hey @cyberhorsey @mask-pp !

This subfolder includes 2 executables - i was doing it previously - a "blob-catcher" and a "server".

Blob-catcher does nothing else but listening on BlockProposed events, and if it sees a blob is used (blobUsed) inside , then it will get the blobHash, queries lighhouse for sidecar (blobs) with blockId and constructs the blobHash from the commitment, and compares it. If it matches, it stores it into DB (MongoDB). This way we are sure we store Taiko related blobs in our DB.

Server on the other hands just tries to retrieve the blob based on blobHash(es).

This is an MvP/PoC, it works but if it does not fit into the styling, maybe it is the best if you guys do the finishing touches (logs / command line arguments, etc.) because most probably it would take me much more time. I guess it is not the highest prio (for anyone) since it is proven to be working - if config vars set correctly, currently the even hash is wron, because it has changed lately - but it is definitely working. (via the readme there is a small howto).

Please help me get this into shape, where it fits with the current go code, as i know you are the go-masters here.

adaki2004 avatar Mar 09 '24 11:03 adaki2004