taiga-ui icon indicating copy to clipboard operation
taiga-ui copied to clipboard

feat(addon-doc): support target property for links

Open splincode opened this issue 1 year ago • 2 comments

splincode avatar Feb 26 '24 08:02 splincode

Pull request was closed :heavy_check_mark:

All saved screenshots (for current PR) were deleted :wastebasket:

lumberjack-bot[bot] avatar Feb 26 '24 08:02 lumberjack-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (v3.x@f8607a1). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             v3.x    #6876   +/-   ##
=======================================
  Coverage        ?   60.58%           
=======================================
  Files           ?       90           
  Lines           ?      987           
  Branches        ?      103           
=======================================
  Hits            ?      598           
  Misses          ?      370           
  Partials        ?       19           
Flag Coverage Δ
addon-charts ∅ <ø> (?)
addon-doc 60.58% <ø> (?)
summary 60.58% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 26 '24 09:02 codecov[bot]

Visit the preview URL for this PR (updated for commit cb752fc):

https://taiga-ui--pr6876-splincode-fix-doc-5f1tcyne.web.app

(expires Tue, 27 Feb 2024 10:02:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

github-actions[bot] avatar Feb 26 '24 09:02 github-actions[bot]

BundleMon

Files updated (2)
Status Path Size Limits
:white_check_mark: demo/browser/main.(hash).js
386.08KB (+1.42KB +0.37%) +10%
:white_check_mark: demo/browser/runtime.(hash).js
40.75KB (+105B +0.25%) +10%
Unchanged files (3)
Status Path Size Limits
:white_check_mark: demo/browser/vendor.(hash).js
213.01KB +10%
:white_check_mark: demo/browser/polyfills.(hash).js
11.25KB +10%
:white_check_mark: demo/browser/styles.(hash).css
1.39KB +10%

Total files change +1.52KB +0.23%

Groups updated (1)
Status Path Size Limits
:white_check_mark: demo/browser/*..js
2.37MB (+10.86KB +0.45%) -

Final result: :white_check_mark:

View report in BundleMon website ➡️


Current branch size history | Target branch size history

bundlemon[bot] avatar Feb 26 '24 09:02 bundlemon[bot]

I think that's excessive. Can we just add rel="noreferrer noopener" there? What's the potential downside?

waterplea avatar Feb 26 '24 11:02 waterplea