taiga-ui icon indicating copy to clipboard operation
taiga-ui copied to clipboard

feat(core): `Dialog` improve automatic typing

Open waterplea opened this issue 1 year ago • 3 comments

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Refactoring
  • [ ] Build or CI related changes
  • [ ] Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • [ ] Yes
  • [ ] No

waterplea avatar Apr 10 '23 12:04 waterplea

Failed tests :x:

After <= Diff => Before

demo.cy.ts/editor/groups/__diff_output__/2.diff.png

(updated for commit b02466ee07e158763651b564c91008d65fd83f93)

lumberjack-bot[bot] avatar Apr 10 '23 12:04 lumberjack-bot[bot]

BundleMon

Files updated (1)
Status Path Size Limits
:white_check_mark: demo/browser/main.(hash).js
327.02KB (-26B -0.01%) +10%
Unchanged files (5)
Status Path Size Limits
:white_check_mark: demo/browser/vendor.(hash).js
200.28KB +10%
:white_check_mark: demo/browser/runtime.(hash).js
38.04KB +10%
:white_check_mark: demo/browser/polyfills.(hash).js
18.28KB +10%
:white_check_mark: demo/browser/scripts.(hash).js
17.9KB +10%
:white_check_mark: demo/browser/styles.(hash).css
1.67KB +10%

Total files change -26B 0%

Groups updated (1)
Status Path Size Limits
:white_check_mark: demo/browser/*..js
2.26MB (-26B 0%) -

Final result: :white_check_mark:

View report in BundleMon website ➡️


Current branch size history | Target branch size history

bundlemon[bot] avatar Apr 11 '23 11:04 bundlemon[bot]

Visit the preview URL for this PR (updated for commit b02466e):

https://taiga-ui--pr4170-typed-dialogs-fmz7r61k.web.app

(expires Tue, 20 Jun 2023 18:06:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

github-actions[bot] avatar Apr 11 '23 11:04 github-actions[bot]