taiga-ui icon indicating copy to clipboard operation
taiga-ui copied to clipboard

fix(core): `Hint` fix offscreen position on small devices

Open waterplea opened this issue 2 years ago • 2 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] The commit message follows Conventional Commits
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Refactoring
  • [ ] Code style update
  • [ ] Build or CI related changes
  • [ ] Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • [ ] Yes
  • [ ] No

waterplea avatar Sep 22 '22 20:09 waterplea

Pull request was closed :heavy_check_mark:

All saved screenshots (for current PR) were deleted :wastebasket:

lumberjack-bot[bot] avatar Sep 22 '22 20:09 lumberjack-bot[bot]

Visit the preview URL for this PR (updated for commit b91673a):

https://taiga-ui--pr2749-hint-pm5d1gt9.web.app

(expires Tue, 27 Sep 2022 07:04:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

github-actions[bot] avatar Sep 22 '22 20:09 github-actions[bot]

Codecov Report

Base: 56.67% // Head: 56.66% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (b91673a) compared to base (f938d49). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2749      +/-   ##
==========================================
- Coverage   56.67%   56.66%   -0.01%     
==========================================
  Files         956      956              
  Lines        9237     9238       +1     
  Branches     1894     1894              
==========================================
  Hits         5235     5235              
- Misses       3591     3592       +1     
  Partials      411      411              
Flag Coverage Δ
addon-charts 73.64% <ø> (ø)
addon-doc 19.12% <ø> (ø)
addon-editor 28.82% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 83.78% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 62.87% <ø> (ø)
core 62.83% <0.00%> (-0.04%) :arrow_down:
kit 61.50% <ø> (ø)
summary 56.66% <0.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/core/directives/hint/hint.component.ts 50.00% <0.00%> (-1.73%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 26 '22 07:09 codecov[bot]

'Well done'

well-done-bot[bot] avatar Sep 26 '22 14:09 well-done-bot[bot]