taiga-ui icon indicating copy to clipboard operation
taiga-ui copied to clipboard

chore(demo): `Table` update `Setup`-section

Open nsbarsukov opened this issue 2 years ago • 2 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] The commit message follows Conventional Commits
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [X] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Refactoring
  • [ ] Code style update
  • [ ] Build or CI related changes
  • [X] Documentation content changes

What is the current behavior?

NG0303: Can't bind to 'tuiCellOf' since it isn't a known property of 'td'
(used in the 'AppComponent' component template).
1. If 'td' is an Angular component and it has the 'tuiCellOf' input, then verify that it is a part of an @NgModule where this component is declared.
2. To allow any property add 'NO_ERRORS_SCHEMA' to the '@NgModule.schemas' of this component.

What is the new behavior?

No error

Does this PR introduce a breaking change?

  • [ ] Yes
  • [X] No

nsbarsukov avatar Sep 20 '22 08:09 nsbarsukov

Pull request was closed :heavy_check_mark:

All saved screenshots (for current PR) were deleted :wastebasket:

lumberjack-bot[bot] avatar Sep 20 '22 08:09 lumberjack-bot[bot]

Visit the preview URL for this PR (updated for commit 5fd5565):

https://taiga-ui--pr2736-table-example-fix-8uuq8bb6.web.app

(expires Wed, 12 Oct 2022 09:35:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

github-actions[bot] avatar Sep 20 '22 08:09 github-actions[bot]

Codecov Report

Base: 61.77% // Head: 64.06% // Increases project coverage by +2.28% :tada:

Coverage data is based on head (8172b51) compared to base (b7d703d). Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2736      +/-   ##
==========================================
+ Coverage   61.77%   64.06%   +2.28%     
==========================================
  Files        1465       42    -1423     
  Lines       17333      423   -16910     
  Branches     2353       23    -2330     
==========================================
- Hits        10708      271   -10437     
+ Misses       6186      150    -6036     
+ Partials      439        2     -437     
Flag Coverage Δ
addon-charts ∅ <ø> (∅)
addon-doc ?
addon-editor ∅ <ø> (∅)
addon-mobile ∅ <ø> (∅)
addon-table 64.06% <33.33%> (-0.38%) :arrow_down:
addon-tablebars ?
cdk ?
core ?
kit ?
summary 64.06% <33.33%> (+2.28%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...table/components/table/directives/row.directive.ts 50.00% <ø> (ø)
...ts/addon-table/components/table/tr/tr.component.ts 41.66% <33.33%> (-3.34%) :arrow_down:
projects/addon-charts/constants/index.ts
projects/kit/components/input-slider/index.ts
projects/kit/components/badge/index.ts
...ects/cdk/exceptions/computed-document.exception.ts
projects/kit/utils/mask/index.ts
.../kit/components/input-count/input-count-options.ts
projects/core/constants/editing-keys.ts
projects/kit/components/action/action.module.ts
... and 1415 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 11 '22 09:10 codecov[bot]

Visit the preview URL for this PR (updated for commit 8172b51):

https://taiga-ui--pr2736-table-example-fix-nek2lsei.web.app

(expires Sat, 15 Oct 2022 09:22:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

github-actions[bot] avatar Oct 14 '22 09:10 github-actions[bot]

BundleMon

Unchanged files (5)
Status Path Size Limits
:white_check_mark: demo/browser/main.(hash).js
317.68KB +10%
:white_check_mark: demo/browser/vendor.(hash).js
205.38KB +10%
:white_check_mark: demo/browser/runtime.(hash).js
33.77KB +10%
:white_check_mark: demo/browser/polyfills.(hash).js
19.92KB +10%
:white_check_mark: demo/browser/scripts.(hash).js
14.92KB +10%

Total files change -1B 0%

Groups updated (1)
Status Path Size Limits
:white_check_mark: demo/browser/*..js
2.15MB (+181B +0.01%) -

Final result: :white_check_mark:

View report in BundleMon website ➡️


Current branch size history | Target branch size history

bundlemon[bot] avatar Oct 14 '22 09:10 bundlemon[bot]

@splincode @vladimirpotekhin could you review again, please ?

nsbarsukov avatar Oct 14 '22 12:10 nsbarsukov

'Well done'

well-done-bot[bot] avatar Oct 14 '22 13:10 well-done-bot[bot]