fix(core): normalize button right icon margin to match left icon

[evantrimboli]

PR Checklist

Please check if your PR fulfills the following requirements:

• [x] The commit message follows Conventional Commits
• [x] Tests for the changes have been added (for bug fixes / features)
• [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• [x] Bugfix
• [ ] Feature
• [ ] Refactoring
• [ ] Code style update
• [ ] Build or CI related changes
• [ ] Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

• [ ] Yes
• [x] No

[codecov[bot]]

Codecov Report

Base: 56.67% // Head: 56.27% // Decreases project coverage by -0.39% :warning:

Coverage data is based on head (0d0c684) compared to base (4b97145). Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2735      +/-   ##
==========================================
- Coverage   56.67%   56.27%   -0.40%     
==========================================
  Files         956      956              
  Lines        9237     9238       +1     
  Branches     1894     1894              
==========================================
- Hits         5235     5199      -36     
- Misses       3591     3622      +31     
- Partials      411      417       +6     

Flag	Coverage Δ
addon-charts	73.64% <ø> (ø)
addon-doc	19.12% <ø> (ø)
addon-editor	28.82% <ø> (ø)
addon-mobile	∅ <ø> (∅)
addon-table	83.78% <ø> (ø)
addon-tablebars	∅ <ø> (∅)
cdk	62.87% <ø> (ø)
core	60.95% <ø> (-1.92%)	:arrow_down:
kit	61.50% <ø> (ø)
summary	56.27% <ø> (-0.40%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...jects/core/components/tooltip/tooltip.component.ts	16.66% <0.00%> (-58.34%)	:arrow_down:
...ts/core/directives/hint/hint-describe.directive.ts	11.76% <0.00%> (-47.06%)	:arrow_down:
...cts/core/directives/hint/hint-options.directive.ts	60.00% <0.00%> (-40.00%)	:arrow_down:
...s/textfield-controller/textfield-size.directive.ts	80.00% <0.00%> (-20.00%)	:arrow_down:
...extfield-controller/textfield-cleaner.directive.ts	80.00% <0.00%> (-20.00%)	:arrow_down:
...ld-controller/textfield-label-outside.directive.ts	80.00% <0.00%> (-20.00%)	:arrow_down:
...jects/core/directives/wrapper/wrapper.directive.ts	63.63% <0.00%> (-18.19%)	:arrow_down:
...imitive-textfield/primitive-textfield.component.ts	64.28% <0.00%> (-11.43%)	:arrow_down:
...eld/value-decoration/value-decoration.component.ts	80.95% <0.00%> (-9.53%)	:arrow_down:
projects/core/directives/hint/hint.component.ts	50.00% <0.00%> (-1.73%)	:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[waterplea]

@evantrimboli thank you for this PR, please run npm run lint --fix on your code (or manually fix quotes). This is supposed to happen in precommit hook, please also see why it didn't happen for you if you plan on contributing in future.

[lumberjack-bot[bot]]

Pull request was closed :heavy_check_mark:

All saved screenshots (for current PR) were deleted :wastebasket:

[waterplea]

Initially this asymmetry was added for chevron icons because space looks to big when you use them. Any idea how to handle this better?

[evantrimboli]

Yeah I understand, that's a bit tricky.

Maybe I'll just keep a local fix where I override the right margin with an appearance selector.