taiga-ui icon indicating copy to clipboard operation
taiga-ui copied to clipboard

🐞 - @taiga-ui/i18n dependency problem

Open hheexx opened this issue 2 years ago • 7 comments

Which @taiga-ui/* package(s) are the source of the bug?

core

Please provide a link to a minimal reproduction of the bug

https://stackblitz.com/edit/taiga-starter

Is this issue blocking you?

Non-Blocking

Description

@taiga-ui/core depends on @taiga-ui/i18n. But dependency is not to specific version same as core but instead has ^ witch means npm pulls latest version.

image

i18n types differ between version a lot and that creates all sorts of random typing problems

Angular version

14.1.0

Taiga UI version

2.60.0

Which browsers have you used?

  • [X] Chrome
  • [X] Firefox
  • [X] Safari
  • [X] Edge

Which operating systems have you used?

  • [X] macOS
  • [X] Windows
  • [X] Linux
  • [X] iOS
  • [X] Android

hheexx avatar Aug 16 '22 12:08 hheexx

I'm not sure if this is the problem

splincode avatar Aug 16 '22 13:08 splincode

Why not?

hheexx avatar Aug 16 '22 16:08 hheexx

Because we have correct dependency in package https://github.com/Tinkoff/taiga-ui/blob/main/projects/core/package.json#L18

splincode avatar Aug 16 '22 16:08 splincode

but ^ means it will get the latest, not the one that is specified

hheexx avatar Aug 16 '22 16:08 hheexx

force pinning some versions is a bad practice for open source projects if you need pin version inside your project, you can fix in your package.json file

"dependencies": {
  "@taiga-ui/core": "^2.60.0",
  "@taiga-ui/kit": "^2.60.0",
  "@taiga-ui/i18n": "2.52.0" // <- also you need re-update your package-lock.json file for fixing it
}

splincode avatar Aug 16 '22 16:08 splincode

@splincode It's internal library of your project and I see no reason why would somebody want to change the version.

Currently simple npm update breaks taigaui in a hard to debug way. I lost a lot of time on this.

At least add @taiga-ui/i18n to a documentation as a standard way of installing taiga.

hheexx avatar Aug 20 '22 19:08 hheexx

@vladimirpotekhin @nsbarsukov @waterplea what do you think about this?

splincode avatar Aug 20 '22 21:08 splincode

won't fix

splincode avatar Dec 21 '22 18:12 splincode