taiga-ui icon indicating copy to clipboard operation
taiga-ui copied to clipboard

[WIP] fix(core): css media breakpoints correction (edge cases)

Open nsbarsukov opened this issue 2 years ago • 3 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [X] The commit message follows Conventional Commits
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [X] Bugfix
  • [ ] Feature
  • [ ] Refactoring
  • [ ] Code style update
  • [ ] Build or CI related changes
  • [ ] Documentation content changes

Does this PR introduce a breaking change?

  • [ ] Yes
  • [X] No

nsbarsukov avatar Aug 11 '22 07:08 nsbarsukov

Workflow with tests failed :x:

I have not found any screenshots diffs. Probably, workflow failed for another reason.

Manually download artifacts of workflow or look into workflow logs to check it.

lumberjack-bot[bot] avatar Aug 11 '22 07:08 lumberjack-bot[bot]

Visit the preview URL for this PR (updated for commit 40ebbfe):

https://taiga-ui--pr2333-media-breakpoints-fi-9c4rbt38.web.app

(expires Sat, 13 Aug 2022 08:56:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

github-actions[bot] avatar Aug 11 '22 07:08 github-actions[bot]

Codecov Report

Merging #2333 (c217305) into main (abb3bc3) will not change coverage. The diff coverage is n/a.

:exclamation: Current head c217305 differs from pull request most recent head 40ebbfe. Consider uploading reports for the commit 40ebbfe to get more accurate results

@@           Coverage Diff           @@
##             main    #2333   +/-   ##
=======================================
  Coverage   58.85%   58.85%           
=======================================
  Files        1032     1032           
  Lines       11500    11500           
  Branches     2206     2206           
=======================================
  Hits         6768     6768           
  Misses       4254     4254           
  Partials      478      478           
Flag Coverage Δ
addon-charts 75.30% <ø> (ø)
addon-doc 27.59% <ø> (ø)
addon-editor 27.60% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 79.59% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 68.22% <ø> (ø)
core 68.26% <ø> (ø)
kit 63.12% <ø> (ø)
summary 58.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 11 '22 07:08 codecov[bot]

'Well done'

well-done-bot[bot] avatar Aug 12 '22 10:08 well-done-bot[bot]