ng-web-apis icon indicating copy to clipboard operation
ng-web-apis copied to clipboard

feat(notification): add service worker support for `@ng-web-apis/notification`

Open nsbarsukov opened this issue 10 months ago • 2 comments

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [X] Feature
  • [ ] Refactoring
  • [ ] Build or CI related changes
  • [ ] Tests related changes
  • [ ] Documentation content changes

What is the new behaviour?

Partially solves https://github.com/taiga-family/ng-web-apis/issues/96

Add support for mobile devices

IOS:

nsbarsukov avatar Oct 18 '23 18:10 nsbarsukov

Visit the preview URL for this PR (updated for commit 8540266):

https://ng-web-apis-common--pr218-notification-api-for-rg2goj9u.web.app

(expires Sat, 16 Dec 2023 11:25:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a9d81cd8541a1a45fa12e730c551222bb3d5ceb9

github-actions[bot] avatar Oct 18 '23 18:10 github-actions[bot]

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (7734a40) 88.84% compared to head (a611f17) 87.31%. Report is 33 commits behind head on main.

:exclamation: Current head a611f17 differs from pull request most recent head 8540266. Consider uploading reports for the commit 8540266 to get more accurate results

Files Patch % Lines
.../notification/src/services/notification.service.ts 30.43% 16 Missing :warning:
...bs/notification/src/tokens/notification-factory.ts 30.00% 7 Missing :warning:
libs/notification/src/utils/provide-sw-push.ts 0.00% 6 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   88.84%   87.31%   -1.53%     
==========================================
  Files         204      208       +4     
  Lines        1210     1246      +36     
  Branches      130      134       +4     
==========================================
+ Hits         1075     1088      +13     
- Misses        109      132      +23     
  Partials       26       26              
Flag Coverage Δ
audio 79.92% <ø> (ø)
canvas 95.97% <ø> (ø)
common 100.00% <ø> (ø)
geolocation 100.00% <ø> (ø)
intersection-observer 98.00% <ø> (ø)
midi 100.00% <ø> (ø)
mutation-observer 100.00% <ø> (ø)
notification 48.33% <32.55%> (-18.34%) :arrow_down:
payment-request 100.00% <ø> (ø)
permissions 78.78% <ø> (ø)
resize-observer 100.00% <ø> (ø)
speech 100.00% <ø> (ø)
storage 100.00% <ø> (ø)
summary 87.31% <32.55%> (-1.53%) :arrow_down:
universal 100.00% <ø> (ø)
view-transition 85.71% <ø> (ø)
workers 98.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 18 '23 18:10 codecov[bot]