maskito icon indicating copy to clipboard operation
maskito copied to clipboard

🚀 - `Date` add support for multi-character `separator`

Open sysmat opened this issue 1 year ago • 6 comments

Which package(s) are relevant/related to the feature request?

@maskito/kit

Description

  • export declare type MaskitoDateMode = 'dd/mm/yyyy' | 'mm/dd/yyyy' | 'mm/yy' | 'yyyy/mm/dd';
  • In Slovenia we use formal format dd. mm. yyyy, but technically dd.mm.yyyy could you add this union type to MaskitoDateMode

sysmat avatar Jun 29 '23 07:06 sysmat

@sysmat you can use parameter separator to get desired format dd.mm.yyyy

import {maskitoDateOptionsGenerator} from '@maskito/kit';

const dateOptions = maskitoDateOptionsGenerator({
    mode: 'dd/mm/yyyy',
    separator: '.'
}); // dd.mm.yyyy

nsbarsukov avatar Jun 29 '23 10:06 nsbarsukov

I see that you also need dd. mm. yyyy format (with spaces).

At present time, separator parameter supports only single character. Let convert this issue to

`Date` add support for multi-character `separator` 

Expected behaviour:

const dateOptions = maskitoDateOptionsGenerator({
    mode: 'dd/mm/yyyy',
    separator: '. ' // 2 characters
}); // dd. mm. yyyy

nsbarsukov avatar Jun 29 '23 10:06 nsbarsukov

const today = new Date();

console.log(
  new Intl.DateTimeFormat('sl-SI').format(today)
); // 29. 6. 2023

nsbarsukov avatar Jun 29 '23 10:06 nsbarsukov

@nsbarsukov thx

sysmat avatar Jun 29 '23 10:06 sysmat

Is @KrollikRoddzer working on this? I was debugging this rn so not sure if I continue or wait it

wladpaiva avatar Apr 23 '24 16:04 wladpaiva

Is @KrollikRoddzer working on this? I was debugging this rn so not sure if I continue or wait it

@wladpaiva Actually, we just planned for him to do it. He has not started doing this yet. So, if you are already debugging this issue and want to contribute – welcome ❤️

I will re-assign this issue to you!

nsbarsukov avatar Apr 24 '24 08:04 nsbarsukov

@nsbarsukov, @sysmat it can be already done https://stackblitz.com/edit/stackblitz-starters-nkq2rt?file=date-mask.spec.js

kmisha avatar Jun 06 '24 12:06 kmisha

@kmisha Unfortunately, it is not yet supported(

Try to enter any complete date string here: https://maskito.dev/kit/date/API?separator=--

nsbarsukov avatar Jun 06 '24 13:06 nsbarsukov

Oh, I see. May I try to fix it?

kmisha avatar Jun 06 '24 15:06 kmisha

@kmisha thx, nice

sysmat avatar Jun 07 '24 09:06 sysmat

Oh, I see. May I try to fix it?

Of course!

nsbarsukov avatar Jun 07 '24 10:06 nsbarsukov