taichi icon indicating copy to clipboard operation
taichi copied to clipboard

python: Remove ui.GUI begin and end

Open Xuanwo opened this issue 3 years ago • 2 comments

  • Previous discussion: https://github.com/taichi-dev/taichi/pull/3055#discussion_r719066130
  • Related issue: https://github.com/taichi-dev/taichi/issues/3015

In PR #3055, we added GUI.sub_window.

So it's possible to use sub_window to replace all usage about GUI.begin and GUI.end.

This will make the API cleaner and easier for users, and help users prevent mismatched begins and ends.

Xuanwo avatar Sep 30 '21 08:09 Xuanwo

Thanks! Please remember to also update the docs and the examples in examples/ggui_examples when you make this change.

AmesingFlank avatar Sep 30 '21 09:09 AmesingFlank

Is this issue still valid?

Xuanwo avatar Sep 15 '22 07:09 Xuanwo