extension icon indicating copy to clipboard operation
extension copied to clipboard

Published 20 hours ago • verified publisher icon tahowallet

Refactor content script injection

Open aurelsziebert opened this issue 2 years ago • 2 comments

Closes #2833

Remove the build time window provider injection because CSP can't be loosened.

aurelsziebert avatar Jan 05 '23 06:01 aurelsziebert

Should this change to be bound to SUPPORT_MANIFEST_V3 feature flag @greg-nagy?

aurelsziebert avatar Jan 05 '23 06:01 aurelsziebert

Should this change to be bound to SUPPORT_MANIFEST_V3 feature flag @greg-nagy?

💯

Yes it should be

greg-nagy avatar Jan 05 '23 06:01 greg-nagy

In addition to manifest v3 not being top of mind right now, it's not entirely clear to me why this wouldn't trigger the issues we originally inlined the script to avoid (https://github.com/tahowallet/extension/issues/1117). Indeed, the original approach to this injection was a script src and we moved away from it (reasoning less clear, https://github.com/tahowallet/extension/commit/61b7f0350d2f994b982b3c2c5cba68b2a7974a8d ).

Going to close this for now alongside other manifest v3 work, but if and when we circle back we'll want to make sure we're not reintroducing a bug we had previously fixed.

Shadowfiend avatar Apr 14 '23 19:04 Shadowfiend