extension icon indicating copy to clipboard operation
extension copied to clipboard

Ledger: Upgrade Flow to include dropdown

Open VladUXUI opened this issue 2 years ago • 4 comments

Problem

Since we are adding more chains that don't use Ethereum derivation path, we need a way for users to select what chain they want to start with. Each chain has a different derivation path and a different app that users need to use.

Solution

Start the Ledger Flow by asking users what chain they would like to start with

Changes needed

  • [ ] Add select network to First Ledger screen
  • [ ] Change content of second scree (Take steps bellow) to tell users what app they need to open (Step 3 - Open Rootstock App)
  • [ ] On second screen, add text in graphic to say what chain they selected
  • [ ] Error handling inside app (sign tx screens mostly). We need to change the screens that say "Open Ethereum up" to be dependent of chain they are trying to transact with
  • [ ] Change flow when users click on "add wallet" for Ledger. Default to what ever chain they are on.

Open question

  • If i onboard with Rootstock, does that mean i won't see my ETH accounts?

Design

image

Figma Link

Figma Link If you need permission to see, let me know and i'll move it to a public file

VladUXUI avatar Nov 15 '22 07:11 VladUXUI

Going to CC @ahsan-javaiid and @alepc253 since this is needed for Rootstock Ledger onboarding. I wouldn't consider this a blocker to launching RSK though.

VladUXUI avatar Nov 15 '22 07:11 VladUXUI

@VladUXUI Why are you mentioning me? How can I help you?

PabloCastellano avatar Nov 15 '22 09:11 PabloCastellano

@VladUXUI Why are you mentioning me? How can I help you?

Ups, sorry. That was a mistake. when i type @alepc253 i get you as suggestion.

VladUXUI avatar Nov 15 '22 09:11 VladUXUI

Hi Tally team 👋

Implementation done here: https://github.com/tallycash/extension/pull/2577

Feel free to review the pull request 🙏

ahsan-javaiid avatar Dec 06 '22 06:12 ahsan-javaiid