extension
extension copied to clipboard
tahowallet
Swaps aren't displayed properly in the wallet activity list
- [ ] They aren't showing up as swaps in the wallet activity list, regardless of the network
- [x] The "0x Router" name isn't showing up in the signature request on Optimism
Do you recall the last time or version you saw asset swaps populating correctly in the activity item list? Digging through git history I can't seem to find a release where we correctly set an annotation's type to asset-swap
It's been a long time, but I do believe I've seen it before... I can dig a little tomorrow.
On the naming side, any idea why the names here aren't being picked up? I imagine it was my enrichment overhaul PR... the gift that keeps on giving :bug:
Unclear but yeah definitely has to do with enrichment. 0x Router is properly being picked up on the tx preview screen
😕❓
The "0x Router" name isn't showing up in the signature request on Optimism
This is fixed in #2219
We've never correctly displayed swaps in the activity list. This requires enrichment information that we can't infer from transactions straightforwardly. We can do a lot of lifting for that, or we can allow internal dApps to provide it for us (or both, obviously). The latter is more solvable, have something for this now.
Maybe we at least can handle in-wallet swaps properly? If a user makes a swap inside the wallet it would look less sus to display it as a swap and not a contract interaction. Dapps swaps displayed as contract interactions are not the best UX but it makes more sense to me.
