extension icon indicating copy to clipboard operation
extension copied to clipboard

Published 20 hours ago • verified publisher icon tahowallet

CEX deposit address recognized as contract address - warns for loss of funds

Open Naxsun opened this issue 2 years ago • 6 comments

Discord Discussion Link

na

What browsers are you seeing the problem on?

Chrome

What were you trying to do?

Send funds to a CEX

What did not work?

Wallet warns this is a contract address and will result in a loss of funds

Screen Shot 2022-09-04 at 14 37 06

Version

v0.15.0

Relevant log output

No response

Naxsun avatar Sep 04 '22 18:09 Naxsun

Example: warning is received when sending funds to Coinlist (they use a contract), does not apply to Binance

Naxsun avatar Sep 05 '22 15:09 Naxsun

Just needs a copy update IMO. Ideas on what it should say @Naxsun?

mhluongo avatar Sep 06 '22 02:09 mhluongo

I assume we can not distinguish between a token contract and a different smart / CEX contract?

If this is the case

  • Was: This is a contract address, sending assets will result in loss of funds
  • Opt 1: This is a contract address, sending assets may result in loss of funds
  • Opt 2: This is a contract address, confirm the address to prevent loss of funds
  • Opt 3: The receiver is a contract address, be sure to verify the address

I'm inclined to option 3

Naxsun avatar Sep 06 '22 07:09 Naxsun

I like 2, 3 is ok too

jagodarybacka avatar Sep 06 '22 12:09 jagodarybacka

I like 1 or 3

0xDaedalus avatar Sep 06 '22 13:09 0xDaedalus

@mr-michael can we make a decision for a tweak for now? Currently also bridges like the native bridge show this message.

I propose to go for: This a contract address, be sure to confirm the address.

Screen Shot 2022-09-18 at 14 44 58

Naxsun avatar Sep 18 '22 12:09 Naxsun

Resolved as part of https://github.com/tallyhowallet/extension/pull/2252

0xDaedalus avatar Feb 15 '23 04:02 0xDaedalus