extension icon indicating copy to clipboard operation
extension copied to clipboard

Replace NetworkSettingsSelector with an explainer on why it is not relevant on Optimism for Optimism transactions.

Open 0xDaedalus opened this issue 2 years ago • 2 comments

This PR replaces the (irrelevant for Optimism) gas selector with an explanation of why editing the gas fee is not as relevant on optimism as it is on other networks.

image

Until we get an optimism-specific design of gas controls I think this is a happy medium. Some background on why our current gas control screens are not a good fit here:

  • Optimism has no mempool, so a transaction is either instantly accepted or rejected - there is no concept of regular / express / instant.
  • The bulk of a transaction's gas cost is rooted in the L1 rollup fee which is not able to be edited at all by the user.
  • Optimism transactions have 4 cost components - Optimism gasLimit, Optimism gasPrice, Ethereum gasLimit, and Ethereum gasPrice.

To Test

  • [ ] Attempt to edit the gas settings of an Optimism transaction - the above screen should pop up in lieu of the EIP-1559 gas controls.

0xDaedalus avatar Aug 22 '22 17:08 0xDaedalus

The styling is off on Chromium

Screenshot from 2022-08-22 20-46-44

mhluongo avatar Aug 23 '22 00:08 mhluongo

I'm not able to recreate the issue on chrome and am running into lots of pain trying to get chromium running on an M1 mac. Anyone else able to troubleshoot this?

0xDaedalus avatar Aug 23 '22 20:08 0xDaedalus

Thanks for the feedback - should be ready for a second look:

image

0xDaedalus avatar Aug 25 '22 12:08 0xDaedalus