browser-extensions icon indicating copy to clipboard operation
browser-extensions copied to clipboard

“Save Editable Page” output missing Formatting and Images

Open sunjam opened this issue 7 years ago • 5 comments

Output of Save Editable Page 41e3f04a-6223-41c4-9e6b-766e7f7e0c2d Output of Save Complete Page e1866875-78e3-411c-bc61-bfd925413704

sunjam avatar Feb 19 '18 19:02 sunjam

This is more or less the intended output of this functionality. If you open it in TagSpaces with HTML viewer with readability mode turned on, it will look much nicer. For now the saving functionality just saves the HTML with all the embedded images (img tags) as data urls.

In the future we may run the readability script before the saving of the HTML file, this will clean some of the unneeded blocks, but will also change heavily the page content ....

uggrock avatar Feb 19 '18 20:02 uggrock

Is this because of the Firefox Quantum release? Thanks for the info, but I just need to capture the complete page from Firefox if that is do-able. I’m happy to contact Mozilla if it helps.

On Mon, Feb 19, 2018 at 12:55 PM Ilian [email protected] wrote:

This is more or less the intended output of this functionality. If you open it in TagSpaces with HTML viewer with readability mode turned on, it will look much nicer. For now the saving functionality just saves the HTML with all the embedded images (img tags) as data urls.

In the future we may run the readability script before the saving of the HTML file, this will clean some of the unneeded blocks, but will also change heavily the page content ....

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tagspaces/browser-extensions/issues/4#issuecomment-366800676, or mute the thread https://github.com/notifications/unsubscribe-auth/ABtFZq6-gnLh6S3vw2kXS5X_xNgmpPZwks5tWd_PgaJpZM4SLBgs .

sunjam avatar Feb 19 '18 21:02 sunjam

@uggrock I opened a page in read mode (Firefox 59b10) and it saved very nicely from here (though the images don't show up).

It would definitely be nice to see some improved scripting to strip out useless elements and include the images.

@sunjam thanks for filing this one :)

aproposnix avatar Feb 20 '18 09:02 aproposnix

Hi, please find attached a zip containing a page I just created with the Firefox extension, it has one embedded image, please confirm you can read it. Can you please send me your results from saving pages? sample-page.zip

uggrock avatar Feb 20 '18 10:02 uggrock

Sample page seems okay, but having trouble with “Editable Page” save from the Nextcloud Discourse help forum.

Here is the help forum live page. and next is how it is clipped by Tagspaces webclipper as editable html. Had tore-save as pdf before I could upload it from my ios device...

app ideas - Nextcloud community.pdf

sunjam avatar Mar 03 '18 17:03 sunjam