basic custom quote support

[TheBotlyNoob]

[codecov-commenter]

Codecov Report

Merging #544 (fdb46f5) into master (add7406) will increase coverage by 0.30%. The diff coverage is 86.49%.

@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
+ Coverage   61.28%   61.58%   +0.30%     
==========================================
  Files          32       32              
  Lines       15639    15837     +198     
==========================================
+ Hits         9584     9754     +170     
- Misses       6055     6083      +28     

Flag	Coverage Δ
unittests	61.58% <86.49%> (+0.30%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/reader/ns_reader.rs	63.71% <ø> (ø)
src/events/mod.rs	70.58% <25.00%> (-1.06%)	:arrow_down:
src/reader/mod.rs	94.57% <80.95%> (-0.49%)	:arrow_down:
src/events/attributes.rs	92.90% <88.54%> (-0.59%)	:arrow_down:
src/de/map.rs	72.36% <100.00%> (-0.44%)	:arrow_down:
src/name.rs	87.85% <100.00%> (+0.02%)	:arrow_up:
src/reader/buffered_reader.rs	85.44% <100.00%> (+0.06%)	:arrow_up:
src/reader/slice_reader.rs	100.00% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[Mingun]

Thanks for PR! Could you please describe your use-case, why you need quotes other than " or '?

You should run cargo fmt and at the same time you could squash all commints into one and --force-with-lease push it.

Also note, that each new feature requires a test cases for it, but I think, we could wait with that until you describes rationale for this change. Especially confusing for me why you need different open and close delimiters?

[TheBotlyNoob]

I would like this primarily for parsing HTML-like languages (Svelte, JSX) that use curly brackets in attributes

[Mingun]

Anyway, your should also add a point to the Changelog.md under New Features section.

[dralley]

@TheBotlyNoob Do you intend to continue this work?

[TheBotlyNoob]

I don't think so, sorry. I've gotten caught up in other projects. I seem to do that a lot :/.