pass-otp icon indicating copy to clipboard operation
pass-otp copied to clipboard

Pass bash completion does not work with the otp command

Open ghost opened this issue 8 years ago • 13 comments

Hi,

Pass bash completion does not work when using the otp command in Ubuntu (with other non pass-otp commands it does work).

I am using pass v1.7 and pass-otp v1.0.0.

Thanks

ghost avatar Apr 14 '17 18:04 ghost

I wouldn't expect it to work unless the completion function was extension-aware, and it's not.

I'd report this as a general issue to the pass mailing list, as there's nothing this project can do to enable completion without support from upstream.

tadfisher avatar Apr 14 '17 23:04 tadfisher

Could we modify the installation procedure to edit the bash completion information provided by upstream? It seems a sed of that file could get us the completion, unless we can get upstream to support generalized plugin completion somehow.

This would require us to do some level of integration testing against new versions of pass though in case this file changed and broke the sed.

bexelbie avatar Nov 05 '17 12:11 bexelbie

No, I'm not going to modify files packaged by another application.

I'll work on generalizing completion in pass itself.

tadfisher avatar Mar 03 '18 22:03 tadfisher

Just linking the corresponding issues of other extensions: https://github.com/roddhjav/pass-update/issues/9 and https://github.com/palortoff/pass-extension-tail/issues/4

innir avatar Mar 06 '18 13:03 innir

I'm vote for this iussue...pass-extension-tail have found a solution for this, see here https://github.com/palortoff/pass-extension-tail/blob/master/completion/pass-tail.bash.completion

GFdevelop avatar Oct 09 '18 16:10 GFdevelop

Hey @tadfisher !

I'm wondering if you made any progress in generalizing completion in pass as you mentioned last year in your comment?

The thing that drives me nuts with pass otp is the lack of tab completion!

micah avatar Apr 11 '19 20:04 micah

Looks like the bash completion added in 1.7.3 needs to be updated as the extension method isn't working. I see a patch proposed from Feb 2 on the mailing list but no action, so I bumpted it.

bexelbie avatar Apr 28 '19 16:04 bexelbie

This now seems to be possible:

  • https://github.com/palortoff/pass-extension-tail/issues/4#issuecomment-417101895
  • https://github.com/roddhjav/pass-update/commit/e81139302fd7597393e39e56742b00440482f4e4
  • https://git.zx2c4.com/password-store/commit/?id=6a6222eef23d25bec90015e49bd69c42062434ee

NilsIrl avatar Jan 26 '20 00:01 NilsIrl

@tadfisher You haven't been active in a long time (in regards to pass-otp), what should we do going forward?

  • Give merge access to someone else? So that at least PRs can get through.?
  • Should we fork?

NilsIrl avatar Mar 27 '20 13:03 NilsIrl

Perhaps we can add more committers @tadfisher ?

bexelbie avatar Apr 27 '20 09:04 bexelbie

This is still broken I think? I'll source the otp completion manually for now but would be cool if this just worked!

heavyimage avatar Sep 17 '22 17:09 heavyimage

Is this task dead?

The bash completion is still missing in pass-otp...

ghost avatar Apr 21 '23 12:04 ghost

I've just created a pull-request for pass itself https://github.com/zx2c4/password-store/pull/5

xundeenergie avatar Jun 21 '23 21:06 xundeenergie