fastapi_mcp
fastapi_mcp copied to clipboard
Fix duplicated 'http.response.start' event error during client session disconnection
Describe your changes
When a client session is disconnected, the handle_mcp_connection() function returns None, which the server processes as a JsonResponse, triggering the 'http.response.start' event. To prevent the 'http.response.start' event from occurring, it was modified to return a VoidResponse that does not generate any message.
For reference, this error always occurs when the SSE client session is disconnected, regardless of middleware registration.
Issue ticket number and link (if applicable)
#171
Screenshots of the feature / bugfix
Checklist before requesting a review
- [ ] Added relevant tests
- [ ] Run ruff & mypy
- [ ] All tests pass
I can confirm that it's also fixing the #171 for me
+1 to this PR, solved the issue for us as well