obsidian-another-quick-switcher icon indicating copy to clipboard operation
obsidian-another-quick-switcher copied to clipboard

FR: Allow setting of hotkeys in dialogs

Open brimwats opened this issue 3 years ago β€’ 3 comments

I don;t use hover editor all that much, so I would love to make open in new pane crtl alt enter` but there is currently no way to customize those. Thanks for your amazing plugin!

brimwats avatar Aug 17 '22 21:08 brimwats

Thank you for your FR, @brimwats πŸ‘

tadashi-aikawa avatar Aug 18 '22 13:08 tadashi-aikawa

@tadashi-aikawa A similar issue arrises with 0.16 and the introduction of tabs as a new hotkey is defined by default: "cmd alt ↡" opens a link into a new pane on the right.

It'd be nice to have the same hotkeys for opening files mirrored in this plugin. Or, in line with this FR at least give the opportunity to change the hotkeys.

tim-hilde avatar Aug 31 '22 10:08 tim-hilde

@tim-hilde 100% agree. I am going to implement it in the next major release πŸ‘

tadashi-aikawa avatar Aug 31 '22 10:08 tadashi-aikawa

Hi, @brimwats @tim-hilde

I have released v7.0.0-beta8 πŸš€

To be honest, I'm not sure how it would work on macOS correctlyπŸ˜…. If anyone uses macOS and BRAT, it would be great to try the beta version πŸ™

For details: https://github.com/tadashi-aikawa/obsidian-another-quick-switcher/discussions/101#discussion-4357986

tadashi-aikawa avatar Sep 19 '22 08:09 tadashi-aikawa

@tadashi-aikawa

Yeah, this works! Great work and thank you so much!

tim-hilde avatar Sep 19 '22 10:09 tim-hilde

Released in v7.0.0 πŸš€

tadashi-aikawa avatar Sep 24 '22 08:09 tadashi-aikawa

Can you tell me how to make keyboard shortcuts (for example, ctrl+j) work in all keyboard layouts (English and, for example, Russian)?

tonygrr avatar Oct 21 '22 10:10 tonygrr

that's not possible unless we're talking on the level of how a computer sees a keyboard, like 0x0c or something. the two examples you gave; Russian doesn't use J, it uses Cyrillic. keyboard layouts are also quite different

brimwats avatar Oct 21 '22 15:10 brimwats

@tonygrr If they have an event.key, it might be possible to set the shortcut keys.

image image

tadashi-aikawa avatar Oct 21 '22 15:10 tadashi-aikawa

@tadashi-aikawa unfortunately, for Russian and English layout event.key of the same button is different.

Is it possible to improve this functionality to eliminate this problem? Before v. 7.0.0, navigation worked with any keyboard layout. Maybe there is a way to allow the user to configure multiple keyboard shortcuts for the same action?

tonygrr avatar Oct 24 '22 11:10 tonygrr

@tonygrr Do you use both Russian and English layouts?

Before v. 7.0.0, navigation worked with any keyboard layout.

What is navigation specifically? Between 6 and 7, I didn't change most actions related to hotkeys (in dialog) except for a few ones.

tadashi-aikawa avatar Oct 24 '22 14:10 tadashi-aikawa

Do you use both Russian and English layouts?

Yeah.

Between 6 and 7, I didn't change most actions related to hotkeys (in dialog) except for a few ones.

I don't remember exactly on which version I started having problems, but at one point after updating the plugin, I stopped navigating through the search results using the ctrl+j/k shortcuts. I thought this was due to the introduction of the "Customizable hotkeys in dialogs" feature in v. 7.0.0.

I recorded a gif with work of plugin "Another Quick Switcher" v. 6.3.2, where you can see that keyboard shortcut ctrl+j/k works with any keyboard layout (note the language switch in the lower right corner).

another quick switcher

tonygrr avatar Oct 24 '22 16:10 tonygrr

@tonygrr Thank you for details!

I have found the differences and a solution. I'll fix it πŸ‘

tadashi-aikawa avatar Oct 24 '22 23:10 tadashi-aikawa

@tonygrr Fixed in https://github.com/tadashi-aikawa/obsidian-another-quick-switcher/issues/118#issuecomment-1289794754

tadashi-aikawa avatar Oct 24 '22 23:10 tadashi-aikawa