node-damerau-levenshtein icon indicating copy to clipboard operation
node-damerau-levenshtein copied to clipboard

Published 20 hours ago • verified publisher icon tad-lispy

Rename arguments

Open whyboris opened this issue 5 years ago • 4 comments

This PR:

  • renames arguments
  • cleans up the formatting for the index.js file 👍
  • changes var to let and const -- it's been enough years that it shouldn't cause trouble for anyone I think 😅
  • removes arbitrary limit of 100 ⚠️
  • moves a few conditional statements before needlessly filling the matrix if conditions hold 🚀

whyboris avatar May 13 '19 05:05 whyboris

npm test still shows 18 passing -- no errors introduced 🙆‍♂

whyboris avatar May 13 '19 05:05 whyboris

This PR makes quite a few changes, please let me know if you'd like me to undo any of them 👌

After you approve whichever changes should get merged, I'll update the CHANGELOG 😀

whyboris avatar May 13 '19 06:05 whyboris

Hey, thanks! I havn't looked at the code yet, but from your comments it looks like a very welcome changes. I'm quite busy this week, but I promise to review as soon as I have some extra time.

tad-lispy avatar May 13 '19 09:05 tad-lispy

No worries -- and no rush 👌 Hope your week is as stress-free as possible 🎐

whyboris avatar May 13 '19 10:05 whyboris