tachyons icon indicating copy to clipboard operation
tachyons copied to clipboard

Remove outline styling to allow default browser selection elements

Open musm opened this issue 5 years ago • 5 comments

The outline focus border shows up after you click the element:

E.g.: click a link then this shows up before the page changes image

This border should only show up after hitting Tab

musm avatar Aug 07 '20 21:08 musm

Hiding outline effects is not recommended as far as accessibility is concerned. The browser will add default styles for element outline when element is in focus / tabbed / clicked.

NitinNair89 avatar Oct 02 '20 06:10 NitinNair89

Right and I agree, my suggestion here is not to add any styling to outline effects by default and to allow browsers to apply their default styling, which are more accessibility focused. The default Tachyons outlines are not great from both a design and accessibility perspective.

musm avatar Oct 02 '20 17:10 musm

Gotcha @musm . The title was misleading, a bit. :slightly_smiling_face:

NitinNair89 avatar Oct 02 '20 18:10 NitinNair89

I agree, this should probably be the default behaviour, and is in keeping with Tachyons' ethos. Can we find any other sources to evidence this being best practice in terms of a11y?

orionrush avatar Nov 11 '20 20:11 orionrush

Hello, is this issue still open? I have a project for a software methodology class to contribute to an open source repo and I am very interested in working on this project. Could I be assigned to this issue? Thanks!

ankitakul avatar Feb 03 '21 14:02 ankitakul