Fix undefined variables issue

[allancole]

• Add --preserve-variables option to allow CSS-variables to appear in output.
• Update --minify option to make minification work again.
• Fix :root selector typo.
• Recompile the CSS with all the CSS-variables intact :-)

Fixes: #14

[jalcine]

gently bumps this PR

[jalcine]

I’ve had to downgrade my library in order to keep things working. Is there any interest in merging these changes to keep this library working?

(Originally published at: https://v2.jacky.wtf/post/002b6721-da8f-4a04-a904-fd376e10ce3e)

[orionrush]

There is a vast darkness between stars, even when traveling at the speed of tachyons....

On Sat, 11 Jul 2020 at 4:24 am, Jacky Alciné [email protected] wrote:

I’ve had to downgrade my library in order to keep things working. Is there any interest in merging these changes to keep this library working?

(Originally published at: https://v2.jacky.wtf/post/002b6721-da8f-4a04-a904-fd376e10ce3e)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tachyons-css/tachyons-custom/pull/16#issuecomment-656977871, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGANNVS3X64HLSNR7GKOI3R27LP7ANCNFSM4M5AWVDQ .

--

Sent on my mobile device ... 100% typo guarantee

M: +44 (0) 796 456 5153 orionrush.com instagram.com/orionrush twitter.com/orionrush

[allancole]

@mrmrs / @johno, do either of you have a second to review and merge this small but necessary PR :-)

[bradobro]

@allancole thanks for the fix, really helped me out.

I'm cool with this patch, but noticed that correcting _variables.css (root: should be :root) is the only fix needed to restore former behavior.

The --preserve-variables is great for new browsers. Thanks for highlighting that. I'd like to see package.json stay as you propose here, but maybe add a script, npm legacy:css to hard code custom props.

Thanks again for the fix!

[Spittal]

I kind of think that the Tachyons team doesn't care about this repository. But there's a lot of variables that are used in source that are not defined in the variables.css for example:

    --border-width-none: 0;
    --border-width-1: 0.2rem;
    --border-width-2: 0.4rem;
    --border-width-3: 0.8rem;
    --border-width-4: 1.6rem;
    --border-width-5: 3.2rem;

    --black: #000;
    --near-black: #111;
    --dark-gray: #333;
    --mid-gray: #555;
    --gray: #777;
    --silver: #999;
    --light-silver: #aaa;
    --moon-gray: #ccc;
    --light-gray: #eee;
    --near-white: #f4f4f4;
    --white: #fff;
    --transparent: transparent;
    --black-90: rgba(0,0,0,.9);
    --black-80: rgba(0,0,0,.8);
    --black-70: rgba(0,0,0,.7);
    --black-60: rgba(0,0,0,.6);
    --black-50: rgba(0,0,0,.5);
    --black-40: rgba(0,0,0,.4);
    --black-30: rgba(0,0,0,.3);
    --black-20: rgba(0,0,0,.2);
    --black-10: rgba(0,0,0,.1);
    --black-05: rgba(0,0,0,.05);
    --black-025: rgba(0,0,0,.025);
    --black-0125: rgba(0,0,0,.0125);
    --white-90: rgba(255,255,255,.9);
    --white-80: rgba(255,255,255,.8);
    --white-70: rgba(255,255,255,.7);
    --white-60: rgba(255,255,255,.6);
    --white-50: rgba(255,255,255,.5);
    --white-40: rgba(255,255,255,.4);
    --white-30: rgba(255,255,255,.3);
    --white-20: rgba(255,255,255,.2);
    --white-10: rgba(255,255,255,.1);
    --white-05: rgba(255,255,255,.05);
    --white-025: rgba(255,255,255,.025);
    --white-0125: rgba(255,255,255,.0125);

As of 4.9.8 all of these variables are being referenced in source, but aren't in the variables file. It might be worth adding them back in.

[bradobro]

I like that idea.