tachiyomi icon indicating copy to clipboard operation
tachiyomi copied to clipboard

Toast message not displaying properly in light mode

Open TheurgicDuke771 opened this issue 1 year ago • 2 comments

Steps to reproduce

Issue Description:

While updating a category or library we got toast message. While using light mode the message is displayed in Dark text in Dark background making it unable to read.

Steps to reproduce:

Try to update category/library in light mode.

Expected behavior

In light mode Toast message should be displayed in dark text on light background.

Actual behavior

In light mode Toast message is displayed in dark text on dark background, making it unable to read.

Crash logs

No response

Tachiyomi version

0.13.6

Android version

Android 13

Device

Google Pixel 6a

Other details

Screenshot in light mode [Which is having the issue]: Toast_LightMode

Toast is displayed properly in dark mode (i.e. - light text on dark background). Screenshot in dark mode [Which is displayed properly]: Toast_DarkMode

Acknowledgements

  • [X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • [X] I have written a short but informative title.
  • [X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
  • [X] I have tried the troubleshooting guide.
  • [X] I have updated the app to version 0.13.6.
  • [X] I have updated all installed extensions.
  • [X] I will fill out all of the requested information in this form.

TheurgicDuke771 avatar Sep 12 '22 05:09 TheurgicDuke771

@ivaniskandar I think you mentioned this before? Was it something to do with how the context is handled in newer versions of Android?

arkon avatar Sep 18 '22 15:09 arkon

That is for locale I think and this should be fixed on preview by https://github.com/tachiyomiorg/tachiyomi/commit/b0520df1dd4ff169f03b744954e181df94459efe. Though on Android 12+ the toast is always using light mode toast which I think is related to the app's target sdk.

ivaniskandar avatar Sep 21 '22 06:09 ivaniskandar

Issue resolved in latest stable released, hence closing it.

TheurgicDuke771 avatar Nov 01 '22 16:11 TheurgicDuke771