tachiyomi icon indicating copy to clipboard operation
tachiyomi copied to clipboard

Compose rewrite issues

Open arkon opened this issue 2 years ago • 4 comments

This is a tracking issue for various problems with the Jetpack Compose rewrite.

General:

  • [x] No fast scroll
  • [ ] Different ripple color
  • [ ] Performance issues
  • [x] No appbar elevation lift on content scroll
  • [ ] Inconsistent incognito/downloaded only banner visibility
  • [x] Inconsistent controller/screen/scaffolds
  • [ ] Missing range selection in library
  • [ ] No tooltips (e.g., appbar actions; https://issuetracker.google.com/issues/171674404)

History:

  • [x] Date grouping is repeated
  • [x] Appbar elevation isn't reset when scrolled back to the top
  • [x] General performance issues (should look into @Stable/@Immutable usage)
  • [x] Padding of reset checkbox option in remove dialog
  • [x] Broken/failed to load covers don't show the placeholder
  • [x] Jumping to next section when an item is deleted
  • [x] Nav bar inset padding needs to be adjusted
  • [x] History/library data being lost on SQL upgrade for some users

arkon avatar Apr 17 '22 14:04 arkon

  • [x] Eviscerate ripple

Screenshot_20220417-174710_Tachibear.png

CrepeTF avatar Apr 17 '22 16:04 CrepeTF

  • [x] History won't update after reading a chapter

Most likely due to the reader not using SQLDelight

ghostbear avatar Apr 26 '22 20:04 ghostbear

  • [ ] Jumping to next section when an item is deleted

Might be related to https://github.com/cashapp/sqldelight/issues/2591 and/or https://github.com/cashapp/sqldelight/issues/2434 as it also crashes when deleting on last page

ghostbear avatar Apr 27 '22 08:04 ghostbear

Currently having a bunch of issues related to missing state updates:

  • #7418
  • #7834
  • #7866

stevenyomi avatar Aug 27 '22 16:08 stevenyomi

Breaking out the library selection issue to #8071.

The other remaining ones are either already individual issues are broad enough that we'll address them when possible (e.g. tooltip support).

arkon avatar Sep 24 '22 16:09 arkon