tabula-java icon indicating copy to clipboard operation
tabula-java copied to clipboard

Encapsulate the method's of rulings from class Page

Open ShienF opened this issue 2 years ago • 2 comments

Encapsulate rulings method from class Page into class Rulings. Make methods about rullings more object-oriented.

ShienF avatar Jan 16 '23 03:01 ShienF

I like this. What do you think @jazzido ?

I'd like to do a little bit of clean-up (e.g. erasing the TODO comment on L26 that's solved by this PR.) but otherwise very into it.

Noting that I haven't actually run the tests with this patch; don't have a dev env set up on this particular laptop.

jeremybmerrill avatar May 30 '23 21:05 jeremybmerrill

and @ShienF thanks very much for the PR and sorry for the wait

jeremybmerrill avatar May 30 '23 21:05 jeremybmerrill