tabula-java icon indicating copy to clipboard operation
tabula-java copied to clipboard

add ffi constructor to CommandLineApp

Open sp1ritCS opened this issue 4 years ago • 2 comments

Good evening, I've created tabula-java bindings for Rust: tabula-rs forge & tabula on crates.io

However, as I'm using JNI rather than shelling out java, I need some way of constructing the CommandLineApp object. This patch adds a constructor with more primitive (array instead of List) parameters that allow creating CommandLineApp programmatically (ik. this "technically" isn't a "CommandLine Application" anymore 🙃).

I also needed the CSVWriter to write newlines as LF, as at least the test files you provide are also ending with LF (otherwise my tests fail).

It's been years since years since I have last written Java, but I don't think I made any major mistake :D (but if I did, please excuse me ;)).

Signed-off-by: Florian "sp1rit"​ [email protected]

sp1ritCS avatar Oct 08 '21 17:10 sp1ritCS

@sp1ritCS and @chezou would this still be useful to you?

jeremybmerrill avatar Feb 05 '24 22:02 jeremybmerrill

For me, I created a simple wrapper within tabula-py https://github.com/chezou/tabula-py/pull/356/files#diff-08b0ea7406259cdf36400759004168d0daf3dbbc73ff7944bbc834686a4ea244R103-R115

So, I don't need this change anymore.

chezou avatar Feb 05 '24 22:02 chezou