[BUG] Combined layout: id "navbar-menu" twice

[aleksblendwerk]

I am just about to get started with Tabler (downloaded the 1.0.0-beta release archive) and decided to start with the layout-combo.html template.

I am confused because I am seeing the ID navbar-menu twice in the demo markup. Also the whole "avatar" and user-related markup is in there twice, once in the aside and once in the header. Is that how it should be, does it really need to be included twice?

(First time user here, so apologies in advance if this has been brought up already or I just did something wrong.)

[brylocode]

@aleksblendwerk Yes, the fact is twice, but is it the id that prevents you from doing something?

[aleksblendwerk]

@brylocode I didn't run into problems like this yet. Mainly I was just confused because the same id was used twice on the same page when I was customizing the given layout. And I was doubting if this is really the 'best practice'. My frontend skills are limited though, so you might as well just consider this a question instead of a bug report.

[nerdoc]

This is not best practice, in fact this is a violation of the HTML specs. an id must only exist once in a HTML document. Another thing: the Interface link has a href="#navbar-base" which is non-existent. This IMHO should be "#" as it's just a dropdown.

Can't the #navbar-menu that appears in the vertical sidebar be renamed to e.g. #navbar_secondary? This bug is now nearly 2 years old, and could be fixed easily - If that's ok for everyone I can mane a PR with just renaming it?

[codecalm]

fixed :)