icons-svelte builds ALL icons, even ones not used

[silveltman]

I'm using @tabler/icons-svelte in my sveltekit project and astro project. When building, it logs the following:

building client 
transforming (8344) ../../sveltekit/fulldev-ui/node_modules/@tabler/icons-svelte/dist/svelte/icons/IconWand.svelte

The above is 1 moment in the build. It takes about 30-60 seconds and goed over every icon

Is this supposed to happen?

[PudottaPommin]

Hey, this relates to #518 and it's at unknown state 😿

[kwhitley]

You'll also notice in dev mode it loads the full 24-25MB (unless you specifically call each icon by it's full @tabler/icons/svelte/dist/svelte/icons/IconName.svelte path. This causes a pretty big delay in even just refreshing a page in dev mode.

[alpap]

same issue here it just bundles everything

[danawoodman]

any word on this? i'm going to stop using Tabler because I can't bear waiting many seconds for each file change with HMR

[ttmx]

any word on this? i'm going to stop using Tabler because I can't bear waiting many seconds for each file change with HMR

As a workaround you can import them like " import IconBattery from '@tabler/icons-svelte/dist/svelte/icons/IconBattery.svelte';" But typescript complains a lot.

[danawoodman]

the combo of no import auto complete and broken typescript types makes this untenable, ended up moving to use Lucide which ironically has the same issue but only loads 7mb instead of the 40mb

is the root export a barrel file like it is with lucide? if so, afaik tree shaking won't work

[danawoodman]

yeah everything is exported via a barrel file so assuming the issue is lack of proper tree shaking

https://github.com/tabler/tabler-icons/blob/master/packages/icons-svelte/src/tabler-icons-svelte.js

perhaps an export file can be auto generated?

[ttmx]

It is definitely hacky, it was just the way I had to make it work, I like tabler icons a lot. I feel this change is much more needed than any new icon, but I don't speak for everyone.

[BahaaZidan]

No news here ?

[codecalm]

I'm working on it here: https://github.com/tabler/tabler-icons/pull/969 🙂

[sapkra]

@codecalm Any update on this? I have seen that you closed your PR and remove the branch. 👀

[codecalm]

@sapkra I've moved it to #993 as a part of biggest improvements

[TheEisbaer]

@codecalm is this fix availalbe in the version 3.0.0-alpha.1 already?

[Plorenzo]

I tested 3.0.0-alpha.1 and the issue is still there, all icons are built regardless of how many you are using.

[MarArMar]

Temporary fix :

Set to this version in package.json :

"@tabler/icons-svelte": "2.30.0",

[mcmxcdev]

Temporary fix :

Set to this version in package.json :

"@tabler/icons-svelte": "2.30.0",

I tried it out and it's actually not true. When you run a Vite build it still transforms all icons if you use the named imports from @tabler/icons-svelte directly.

[MarArMar]

@mcmxcdev It fixes my problem and my problem (https://github.com/tabler/tabler-icons/issues/1003) was marked as a duplicate to this one by @BG-Software-BG

So maybe my problem was wrongly marked as a duplicate then

[Plorenzo]

@sapkra I've moved it to #993 as a part of biggest improvements

Hey @codecalm, 3.0 is out and the issue is still happening.

It would be great if you can share if there is any plans to address this soon or not, so people can decide if they can wait or they need to find other solutions.

It's clear there is quite a bit of us waiting for some clarity on this :)

[mcmxcdev]

You can just define your icons like import IconBolt from '@tabler/icons-svelte/icons/bolt' for the time being until this issue is resolved.

[codecalm]

@Plorenzo I dont have to much experience with Svelte and build process with it, so if you have any ideas create PR with solution, please

[codecalm]

I've fixed it in #1039

import IconAd from "@tabler/icons-svelte/IconAd.svelte";
import IconAdOff from "@tabler/icons-svelte/IconAdOff.svelte";
import IconAdFilled from "@tabler/icons-svelte/IconAdFilled.svelte";

Results:

> vite build

vite v5.1.4 building for production...
✓ 32 modules transformed.
dist/index.html                  0.40 kB │ gzip: 0.28 kB
dist/assets/index-DzadqsTt.css   1.04 kB │ gzip: 0.56 kB
dist/assets/index-Cg3TY0qG.js   13.24 kB │ gzip: 4.80 kB
✓ built in 293ms

[TheEisbaer]

Version 3.0.0:

Importing icons like this

import IconEdit from '@tabler/icons-svelte/icons/edit';
import IconTrash from '@tabler/icons-svelte/icons/trash';

Results in:

vite v5.1.6 building SSR bundle for production...
✓ 225 modules transformed.
vite v5.1.6 building for production...
✓ 208 modules transformed.

Importing icons like this

import { IconEdit, IconTrash } from '@tabler/icons-svelte';

Results in:

vite v5.1.6 building SSR bundle for production...
✓ 5412 modules transformed.
vite v5.1.6 building for production...
✓ 5395 modules transformed.

Named imports results in all icons in the icon pack being transformed during build

[TheEisbaer]

I've found a "solution" to this issue over at lucide-icons lucide-icons/lucide#1944 :

function tablerSvelteImportOptimizer(): import('vite').Plugin {
	return {
		name: 'tabler-svelte optimizer',
		transform(code, id) {
			const ms = new MagicString(code, { filename: id });
			ms.replace(
				/([ \t]*)import\s+\{([^;]*?)\}\s+from\s+['"]@tabler\/icons-svelte['"];/g,
				(match, whitespace: string, importNames: string) => {
					const hasSemi = match.endsWith(';');
					const imports = importNames
						.split(',')
						.map((v) => v.trim())
						.map((name) => {
							const path = name;
							return `${whitespace}import ${name} from '@tabler/icons-svelte/${path}.svelte'${hasSemi ? ';' : ''}`;
						});
					return imports.join('\n');
				}
			);

			if (ms.hasChanged()) {
				return {
					code: ms.toString(),
					map: ms.generateMap()
				};
			}
		}
	};
}

This converts named imports to direct imports during transforming.

[mcmxcdev]

Did anyone try out https://github.com/tabler/tabler-icons/releases/tag/v3.0.1 which supposedly fixes this issue?

UPDATE: I tried out 3.1.0 and if you use named imports e.g. import { IconEdit } from '@tabler/icons-svelte', the issue is still present. I would like to use named imports though eventually, and I am sure others do as well since that is what this issue is about.

Before 3.0.1, import IconEdit from '@tabler/icons-svelte/icons/edit' used to work which changed to import IconEdit from '@tabler/icons-svelte/IconEdit.svelte' now which is the workaround.

[TheEisbaer]

Any update on this? @codecalm

[TheEisbaer]

@codecalm I have found a possible fix, but don’t know how to implement it:

you are exporting each icon separately in the package.json, that causes a huge slowdown for everything.

I have tried manually renaming every icon to Icon.svelte and doing a single export in the package.json and that improved the performance.

again, I don’t know how to implement it, but it’s worth taking a look at i guesss

[rudiv]

I don't know why this keeps going around in circles, but now the whole import Home from "@tabler/icons-svelte/IconHome.svelte"; has changed back, again, to import Home from "@tabler/icons-svelte/icons/home"; for anyone wondering why things are broken after updating.

[BG-Software-BG]

The change was implemented in response to https://github.com/tabler/tabler-icons/issues/1133

[rudiv]

Yeah I understand the change, it's making zero difference in editor performance at my side but the biggest pain is having to update every single import across the entire project. Because it's JS/TS, this is rather tedious and as far as I can see not documented anywhere other than that issue (and the link to it from the changelog). To me, this is a breaking change and should be documented as such.

That's why I've posted it here in case someone like myself comes frantically stumbling to this GitHub wondering why everything has suddenly broken after updating the package.

[mcmxcdev]

I was also surprised about a breaking change as part of a minor release. It took me 30min to update all icon paths in our codebase and it would be nice if there was a codemod for such things to save everyone some time.