tabcmd icon indicating copy to clipboard operation
tabcmd copied to clipboard

tabcmd `get` with `:size` has order of arguments switched from tabcmd 1

Open Pingviinituutti opened this issue 1 year ago • 1 comments

I noticed that specifying the :size option with tabcmd get didn't work and always gave the same size when getting a view with a fixed width and height. However, when I change the following lines it starts working again (permalink to lines https://github.com/tableau/tabcmd/blob/17edb1ece90fc35b78d95f88a82532ae4ad8055d/tabcmd/commands/datasources_and_workbooks/datasources_and_workbooks_command.py#L131)

Image

Is there a reason for why the request options aren't modified with the height and width?

Pingviinituutti avatar Feb 27 '25 16:02 Pingviinituutti

Looks like at least as of 2.0.18 size is somewhat working, but height and width are backwards compared to TabCMD 1.x or VizAlerts. Basically, in TabCMD 1.x or VizAlerts ?:size=1500,500 is 500 pixels for the height and 1500 pixels for the width.

In TabCMD 2.0.18 these would have to be switched to get the same result. ?:size=500,1500

https://help.tableau.com/current/online/en-us/tabcmd_cmd.htm#get-url https://github.com/tableau/VizAlerts/blob/master/docs/user_guide.md

Not sure how important consistency across similar apps is, but if it does differ, it should be mentioned in a TabCMD 2.x user guide.

Still, this is a significant improvement TY for all the hard work!

micmorgan-clgx avatar Jun 25 '25 16:06 micmorgan-clgx