tabcmd icon indicating copy to clipboard operation
tabcmd copied to clipboard

ubuntu and max-x64 executables are missing a dependency

Open jacalata opened this issue 1 year ago • 3 comments

See package validation failures here: https://github.com/tableau/tabcmd/actions/runs/12688585562

Ubuntu: Run ./dist/ubuntu/tabcmd [2842] Module object for pyimod02_importers is NULL! Traceback (most recent call last): File "PyInstaller/loader/pyimod02_importers.py", line 22, in File "", line 259, in load_module File "pathlib.py", line 13, in File "", line 259, in load_module File "urllib/parse.py", line 39, in ModuleNotFoundError: No module named 'ipaddress' Traceback (most recent call last): File "PyInstaller/loader/pyiboot01_bootstrap.py", line 17, in ModuleNotFoundError: No module named 'pyimod02_importers' [2842] Failed to execute script 'pyiboot01_bootstrap' due to unhandled exception! Error: Process completed with exit code 1.

jacalata avatar Jan 09 '25 11:01 jacalata

Seems a known issue in pyinstaller, except it was fixed in 5.12 and I have 5.13. Maybe the runners have a different version? https://github.com/pyinstaller/pyinstaller/issues/7692

jacalata avatar Jan 10 '25 00:01 jacalata

aha - that fix in pyinstaller is assuming python 3.11 or greater, and we were building on 3.9. Perhaps we should move to building on 3.9 and 3.10 but packaging with 3.11?

https://github.com/pyinstaller/pyinstaller/pull/7694/files if sys.version_info >= (3, 11, 4): # required by loader/pymod02_importers.py -> pathlib -> urllib PY3_BASE_MODULES.add('ipaddress')

jacalata avatar Jan 10 '25 00:01 jacalata

This was not fixed. Must be some difference in the repo settings I tested with.

jacalata avatar Jan 10 '25 19:01 jacalata