document-api-python icon indicating copy to clipboard operation
document-api-python copied to clipboard

Published 20 hours ago • verified publisher icon tableau

Implemented Folder-API

Open KernpunktAnalytics opened this issue 8 years ago • 14 comments

Fixes #112

Since this is a vastly different approach, I've created a new branch to clean up the mess and opened up a new pull request. PR #113 can consequently be closed. Feedback from #112 and #113 was integrated into this branch.

Added the ability to:

  • Query all existing folders
  • Add folders
  • Add fields to folders
  • Remove fields from folders

Tests included, as always.

Merry Christmas :)

KernpunktAnalytics avatar Dec 23 '16 20:12 KernpunktAnalytics

Thank you @KernpunktAnalytics !

I will review this as soon as I can... probably after Christmas :)

Merry Christmas!

t8y8 avatar Dec 23 '16 23:12 t8y8

Hey Tyler, thanks for the feedback. I'll fix the tests and try to find some better names in the init-methods. PR will be updated accordingly as soon as I have time for it. Happy new years!

KernpunktAnalytics avatar Jan 02 '17 07:01 KernpunktAnalytics

Thank you for your answers! I replied, and then did another quick review with some easy small stuff.

I need to ponder the way we pass the XML reference around a bit, your implementation may be the right one I just need a less New Years brain to think on it :)

Happy New Years, thanks for your continued work on this!

t8y8 avatar Jan 02 '17 08:01 t8y8

Hey Tyler, sorry for the late response. I've finally had time to integrate your feedback and fix the test failure on python2/pypy.

KernpunktAnalytics avatar Jan 14 '17 11:01 KernpunktAnalytics

@KernpunktAnalytics thanks for the updates!

I'll take a look as soon as I can (A quick scan looks pretty solid) -- I will be in Europe visiting customers but I'll try to get to this quickly :)

t8y8 avatar Jan 14 '17 21:01 t8y8

Hi all,

Sorry to disturb if this is not best practice here - I'm new on Github.

Any news on whether this implementation will be accepted? Looking into (and assessing if I have the skills) to do something similar for hierarchies (), so curious if this is a good reference?

All the best, /Esben

esbenbm avatar Apr 25 '17 14:04 esbenbm

Hi @esbenbm there have been no commits to this repository since january, so I'm not sure if this project is still actively maintained. We currently use this feature internally, and it works without issues and reliably in all projects so far. Assuming that the XML representation of hierarchies (haven't dealt with them so far) is similar to folders, you should be able to use the same approach.

Cheers

KernpunktAnalytics avatar Apr 26 '17 06:04 KernpunktAnalytics

Hi @KernpunktAnalytics

Thanks for the prompt response! I will look into it :-)

Best, /Esben

esbenbm avatar Apr 26 '17 08:04 esbenbm

Any chance this could be merged in? This would be a nice feature to have.

randyoswald avatar Sep 11 '20 18:09 randyoswald

Hi all - am trying to give this repository a little more love, and will merge this soon

jacalata avatar Mar 14 '22 23:03 jacalata

Thanks for the contribution! Before we can merge this, we need @MrTrustworthy to sign the Salesforce.com Contributor License Agreement.

salesforce-cla[bot] avatar Mar 14 '22 23:03 salesforce-cla[bot]

(Will override the salesforce-cla bot if necessary since I can see @KernpunktAnalytics previously approved)

jacalata avatar Mar 14 '22 23:03 jacalata

Hey, I'm the person who originally implemented this.

I don't even have access to the original Account anymore as I haven't been with that company for almost 5 years, so I won't be able to sign anything new. The CLA was originally signed 5 years ago, so I hope you can just use that.

MrTrustworthy avatar Mar 15 '22 07:03 MrTrustworthy

Is this PR still active? This functionality would be very useful.

BenUrwinHipgnosis avatar Oct 29 '23 11:10 BenUrwinHipgnosis