TabPy icon indicating copy to clipboard operation
TabPy copied to clipboard

Fixes incorrect "certificate provided is not valid until ..."

Open jhilyard opened this issue 1 year ago • 3 comments

Fixes https://kb.tableau.com/articles/issue/error-the-certificate-provided-is-not-valid-until-when-starting-tabpy issue: certificate not_before and not_after are naive datetimes in UTC, so the now variable should use datetime.utcnow() not datetime.now().

Currently anyone who installs TabPy and then creates a self-signed certificate to use HTTPS in a time zone west of Greenwich gets an error that the certificate is not yet valid. I found this frustrating enough to fork and provide this fix, since my certificate still won't be valid for over an hour. You can probably also retire the KB article referenced above once merged.

Thanks for your attention!

jhilyard avatar May 03 '23 22:05 jhilyard

Thanks for the contribution! Before we can merge this, we need @jhilyard to sign the Salesforce Inc. Contributor License Agreement.

salesforce-cla[bot] avatar May 03 '23 22:05 salesforce-cla[bot]

@jhilyard thanks for the PR. I think the last step is to sign the "salesforce-cla" then I can merge that for you.

jakeichikawasalesforce avatar Sep 19 '23 19:09 jakeichikawasalesforce

@jakeichikawasalesforce I signed the salesforce-cla previously - when I click the signing link it now says "You already signed the CLA on 2023-05-03" and won't let me do so again. Sorry the merge checker doesn't seem to agree.

jhilyard avatar Sep 19 '23 21:09 jhilyard

https://github.com/tableau/TabPy/pull/638

jakeichikawasalesforce avatar Jun 20 '24 20:06 jakeichikawasalesforce