react-table-library icon indicating copy to clipboard operation
react-table-library copied to clipboard

Published 20 hours ago • verified publisher icon table-library

Support for CommonJS

Open NiclasThobaben opened this issue 2 years ago • 4 comments

Hi, do you plan on supporting a commonJS build of the library or will it stay pure ESM?

NiclasThobaben avatar Feb 23 '23 15:02 NiclasThobaben

I didn't plan to support it. Can't you use ESM in your project?

rwieruch avatar Mar 05 '23 21:03 rwieruch

We do. However, we use some tools, like Jest, which rely on CommonJS. For Jest this is not a huge problem, as it support transformation of dependencies, before execution, but other tools (i.e. cucumber-js) have issues with that.

NiclasThobaben avatar Mar 08 '23 12:03 NiclasThobaben

If this is an easy change, feel free to open a PR :)

rwieruch avatar Mar 15 '23 12:03 rwieruch

It should just be this, no?

image

Audiopolis avatar Apr 29 '24 20:04 Audiopolis