tabcat

Results 167 comments of tabcat

The issue of preventing duplicate connections to the same multiaddr looks like it was handled by https://github.com/libp2p/js-libp2p/commit/0c5957836d1416566f18233f58c92e7db6ab5525#diff-f67bf5a2d5ca417004f9cab5d20bb74d754a6a96cf4e4df6cf540d9a62388090R533-R540 two days after this issue was opened. I'd be happy to work on...

Hi @aannaannyaaa ! Thanks for opening this, and thanks for the very helpful PR description. There are a few issues I've spotted. The first has to do with simple linting...

It looks like the `go-libp2p-pubsub-router` [queries any peer from a peer-join event](https://github.com/libp2p/go-libp2p-pubsub-router/blob/bcd615215aedd9d2f69002d9ad2745f19a09effa/pubsub.go#L537). I'm open to adding this feature.

These tests shouldn't just be copied over, they should be adapted to fit with the tests they are being moved into. Be sure to only add test coverage, something covered...

These tests shouldn't just be copied over, they should be adapted to fit with the tests they are being moved into. Be sure to only add test coverage, something covered...

Yes, feel free to open a PR. Double check that they haven't already been re-implemented. It's possible these tests, or their equivalent already exist in the compliance suite.

The closeRead and reset tests could be moved to the general compliance. And the todo comment can be deleted. The WebRTC specific tests aren't touched.